Direnv: I think direnv should be changed and only emit that error whenever PS1 is part of the diff.

Created on 7 Apr 2020  路  1Comment  路  Source: direnv/direnv

I think direnv should be changed and only emit that error whenever PS1 is part of the diff.

Another workaround is to change the zsh profile configuration to only set, not export the PS1.

_Originally posted by @zimbatm in https://github.com/direnv/direnv/issues/408#issuecomment-610387778_

Usability

Most helpful comment

Even if PS1 is part of the diff, I feel it's too noisy to emit this warning, as the source may very well be a third party script. For instance, activating Python virtualenvs (source <venv>/bin/activate) triggers this warning.

Given that it's easy to locate the ticket and the wiki entry on this topic, I would suggest reverting https://github.com/direnv/direnv/pull/483 entirely.

>All comments

Even if PS1 is part of the diff, I feel it's too noisy to emit this warning, as the source may very well be a third party script. For instance, activating Python virtualenvs (source <venv>/bin/activate) triggers this warning.

Given that it's easy to locate the ticket and the wiki entry on this topic, I would suggest reverting https://github.com/direnv/direnv/pull/483 entirely.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ssbarnea picture ssbarnea  路  5Comments

fschuindt picture fschuindt  路  3Comments

allomov picture allomov  路  3Comments

coulonxyz picture coulonxyz  路  5Comments

osterman picture osterman  路  3Comments