Dietpi: Important | Issues with cron jobs calling DietPi scripts

[MichaIng]

Related issues:

• https://github.com/Fourdee/DietPi/issues/1901
• https://github.com/Fourdee/DietPi/issues/1914
• https://github.com/Fourdee/DietPi/issues/1920

This is a fix everyone should apply, as it breaks DietPi's own cron jobs to work (clearing /var/log hourly + time sync). Currently most cron jobs, executing DietPi scripts, will exit with error.

Fast fix to apply, which will be part of v6.12 as well:

Copy/paste all into term

wget https://raw.githubusercontent.com/Fourdee/DietPi/0f18aa4dc0af8ab910a0173dce8849d5b53c30b0/dietpi/func/dietpi-globals -O /DietPi/dietpi/func/dietpi-globals

For those who are interested:

• Malicious line is https://github.com/Fourdee/DietPi/blob/master/dietpi/func/dietpi-globals#L266, which leads to tput error exiting the whole script.
• On v6.9 local lines; (( lines=(${#input_string}+6)/$(tput cols) )) had same error output but without exiting the script, for whatever reason 😉. If some shell/bash expert knows why the two lines behave differently, please share, as this is interesting to know and might help to prevent further mistakes on this scripting bases 😅.
• The fix above on the one hand reverts back to separate variable declaration and assignment within arithmetic environment, to assure in case of tput the script goes on, on the other hand prevents tput calls (and terminal animation attempts) at all in non-interactive environments.

[sergiud]

Great! This eliminated hourly error notifications by OMV for me.

[kmakisara]

Time sync hourly works without problems.

[eljotx]

Nice! After fix, cron with dietpi-backup (#1901) is working well.

[Fourdee]

Ok, lets mark this as closed. Resolved for v6.12 (great work @MichaIng 👍 ). In the mean time, solution = https://github.com/Fourdee/DietPi/issues/1923#issue-341325599

[aspinks]

i know this is old but i ran this:
wget https://raw.githubusercontent.com/Fourdee/DietPi/0f18aa4dc0af8ab910a0173dce8849d5b53c30b0/dietpi/func/dietpi-globals -O /DietPi/dietpi/func/dietpi-globals
now when i try to install it goes to the drive manager. i exit that and get this:
OK ] DietPi-Software | Installing Sonarr: automatically download TV shows
[ OK ] DietPi-Software | Free space check: path=/ | available=24428 MB | required=500 MB

then it goes to the command prompt.

[MichaIng]

See: https://github.com/MichaIng/DietPi/issues/2724