Dietpi: G_WHIP improvements/additions

[Fourdee]

http://dietpi.com/phpbb/viewtopic.php?f=9&t=2882&p=11077#p11077

[Fourdee]

• G_WHIP_MSG "info" | removed additional var
• G_WHIP_YESNO | added
• G_WHIP_VIEWLOG | added
• All, auto detect screen size, fill screen to x-=6 y-=4 of total.

[MichaIng]

@Fourdee
Great one, I already have so much ideas in how to use them 😄.

About this screen size recognition, I already thought that would make sense maybe for all our whiptail uses? I mean yeah, it is big enough, but on VirtualBox default 640x480 console they are too big, left and right are cut.
But I guess this would need vast rework of content to fit different screen sizes? I didn't look much into whiptail so no idea how much work it would be, just saw that some text is aligned manually.

[Fourdee]

@MichaIng

I mean yeah, it is big enough, but on VirtualBox default 640x480 console they are too big, left and right are cut.

Yep, plan is to roll out G_WHIP to all our scripts, replacing the manual hard coded entries. I just need to add another 2 for array type selection (eg: dietpi-software and dietpi-config)

I'll check the screen size, we can always tweak it if needed based on tput values (eg: if > 100, then cap to 100 etc).

I don't have a VM setup, if you get a chance whats the values of:

tput lines
tput cols

[MichaIng]

@Fourdee

tput lines
25
tput cols
80

Default on VirtualBox images, but adjustable via grub defaults: https://github.com/Fourdee/DietPi/issues/1227

[Fourdee]

To be added:

• 🈯️ G_WHIP_INPUTBOX
• 🈯️ G_WHIP_MENU
  -- test

export G_WHIP_MENU_ARRAY=(

'option1' 'test'
'option2' 'test'
'option3' 'test'

)
G_WHIP_MENU 'Test selection'

###

root@DietPi:~# echo $G_WHIP_RETURNED_VALUE
option3

• 🈯️ G_WHIP_CHECKLIST
  -- test

export G_WHIP_CHECKLIST_ARRAY=(

'option1' 'test' 'off'
'option2' 'test' 'on'
'option3' 'test' 'off'

)
G_WHIP_CHECKLIST 'Test selection'

###

root@DietPi:~# echo $G_WHIP_RETURNED_VALUE
option2 option3

[Fourdee]

mmm, set result var has no effect, but echo $? works...

            export G_WHIP_RETURNED_VALUE=$(whiptail --title "$G_PROGRAM_NAME" --menu "$message" --default-item "$G_WHIP_DEFAULT_ITEM" --cancel-button "Cancel" --backtitle "$G_PROGRAM_NAME" $G_WHIP_SIZE_Y $G_WHIP_SIZE_X $G_WHIP_SIZE_Z "${G_WHIP_MENU_ARRAY[@]}" 3>&1 1>&2 2>&3; result=$?)

🈯️ ; echo $? > /tmp/.G_WHIP_MENU_RESULT works, then result=$(cat /tmp/.G_WHIP_MENU_RESULT)

[Fourdee]

Auto whiptail scaling based on screen dimensions and internal content:
test/notes:

. /DietPi/dietpi/func/dietpi-globals
G_WHIP_CHECKLIST_ARRAY=(

'option1' 'test' 'off'
'option2' 'test' 'on'
'option3' 'test' 'off'
'option4' 'test' 'off'
'option5' 'test' 'off'
'option6' 'test' 'off'
'option7' 'test' 'off'
'option8' 'test' 'off'
'option9' 'test' 'off'
'option10' 'test' 'off'
'option11' 'test' 'off'

)
G_WHIP_CHECKLIST 'Test selection\ntest\ntest\ntest'

. /DietPi/dietpi/func/dietpi-globals
G_WHIP_MSG "test"
G_WHIP_MSG "test\n2"
G_WHIP_MSG "test\n2\nssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss\n4"

[Fourdee]

Automatic scaling of G_WHIP based on:

• Screen size
• Text message size (total lines and character count against screen X)
• Prints maximum Z options (eg: menu) available against the screen size total.

[Fourdee]

Pretty much done, just needs rolling out across all DietPi scripts.

[Fourdee]

Marking as completed, all items added, i'll roll G_WHIP out throughout all scripts gradually (will take some time).