DietPi-Software | pi-hole/AdminLTE update hint

Created on 21 Aug 2016  路  11Comments  路  Source: MichaIng/DietPi

@Fourdee

160821-0001
really annoying.

Enhancement

Most helpful comment

@Fourdee

really annoying.

... is the alert popup on every refresh : https://github.com/pi-hole/AdminLTE/blob/master/header.php#L96

... and three PayPay donation links on one single webpage!
... and loading "https://www.paypalobjects.com/en_US/i/scr/pixel.gif" on every refresh!

I`m back on my old (modded) Pi-hole 2.6.3 ...

160821-0004

All 11 comments

really annoying.

@k-plan

Yep. I'am going to have a rethink about Pihole on DietPi and how we install it. Possibly get rid of our Pihole/fork and use their master branches.

Whats the update link target URL?

@Fourdee

Whats the update link target URL?

https://github.com/pi-hole/AdminLTE/releases

changes: https://github.com/pi-hole/AdminLTE/wiki/Changelog

-16827203

_new logo, used ram in footer, cpu temp. in header, ... but no new pi-hole version_

@Fourdee

really annoying.

... is the alert popup on every refresh : https://github.com/pi-hole/AdminLTE/blob/master/header.php#L96

... and three PayPay donation links on one single webpage!
... and loading "https://www.paypalobjects.com/en_US/i/scr/pixel.gif" on every refresh!

I`m back on my old (modded) Pi-hole 2.6.3 ...

160821-0004

Yep. I'am going to have a rethink about Pihole on DietPi and how we install it. Possibly get rid of our Pihole/fork and use their master branches.

Now i remember why we have a fork.

  • Their install script (https://github.com/pi-hole/pi-hole/blob/master/automated%20install/basic-install.sh) only allows for Lighttpd.
  • /var/www/html, we use /var/www/pihole
  • We dont need to install Git packages.

Ideally, I'd like to rewrite their basic_install.sh script, allow for either Lighttpd/Nginx/Apache2, would make this installation much simplier.
But for me at the moment, its quicker to fork, make some minor changes (eg: disable the update check) and update Pihole forks every < 1month.

@k-plan
Removed the update notifications:
image

@Fourdee

tested on Pine64 with nginx webserver:

  • update notification has gone :smile:
  • click on Pi-hole in top right corner doesn't open a pop-up like on your screen-shot
  • Temp: didn't work on Pine64

pihole

@k-plan
No menu seems to be related to Nginx.

Temp issue related to PineA64, fine on C2.

I dont have a Pine setup at the moment, whats the values of:

cat /sys/class/thermal/thermal_zone0/temp
cat /sys/devices/platform/sunxi-i2c.0/i2c-0/0-0034/temp1_input

@k-plan

click on Pi-hole in top right corner doesn't open a pop-up like on your screen-shot

No menu seems to be related to Nginx.

Yep, something I broke on our fork. Will take a look.

@Fourdee

I dont have a Pine setup at the moment, whats the values of:

sorry, but my Pine64 is 50 miles away and offline. So i can do it earliest next week.

But, if I remember it correct, it was:

cat /sys/class/thermal/thermal_zone0/temp
52

Verify it next week.

@k-plan
Turns out Java script needs quotations lol

Fixed :)

cat /sys/class/thermal/thermal_zone0/temp
52

PiHole must be pulling temp in a different way, I'll test on Pine here and check.

Done, temp readout now working on Pine A64, I'll send a PR to Pihole with above changes.

I'll send a PR to Pihole with above changes.

https://github.com/pi-hole/AdminLTE/pull/129

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Kapot picture Kapot  路  3Comments

aesirteam picture aesirteam  路  3Comments

pgferr picture pgferr  路  3Comments

k-plan picture k-plan  路  3Comments

MichaIng picture MichaIng  路  3Comments