Diem: remove custom_test_frameworks nightly feature

Created on 23 Jul 2019  路  4Comments  路  Source: diem/diem

The custom_test_frameworks nightly feature needs to be removed from the codebase so that we can migrate to using the stable rust compiler.

See #270 for more information.

rust

All 4 comments

I'd consider removing the feature nice to have but not blocking, as we always have the RUSTC_BOOTSTRAP workaround available for test code.

There are many affordances that custom_test_frameworks provides -- like allowing you to filter by filename on the CLI -- and it would be a shame to lose them.

https://github.com/commure/datatest/issues/4 has landed, so this should be possible now. Note that the switch to non-nightly datatest will have to happen concurrently with the switch to the stable release channel.

Awesome! So the real blocker is #284 then. Also just to clarify, this should also work in the event we transition to beta next cycle?

Yeah, sorry about not being clear -- stable includes beta.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rollsmorr picture rollsmorr  路  5Comments

gr0kchain picture gr0kchain  路  5Comments

jingtying picture jingtying  路  3Comments

http-km picture http-km  路  3Comments

toshirot picture toshirot  路  3Comments