Diaspora: Add mention and PM icons to hovercards

[goobertron]

I think it would be useful to add @ (mention) and envelope (conversation) icons in hovercards, assuming of course that you and that person have the appropriate sharing relationship.

The way I see this working is that if you click the mention or envelope icon, a pane pops up containing either the publisher or the new conversations page, as appropriate. The person will be automatically mentioned or included in the conversation, as appropriate.

Then when you click 'Share' (in the publisher) or 'Send' (in the conversation), the pane disappears and you are back where you started - you have not left the place where you found the hovercard.

If others consider this a good idea, we can then try to think of a good place on the hovercards to place these icons!

[lu-x]

related https://github.com/diaspora/diaspora/issues/6542

[angerella10]

I'm currently working on it. :)

[angerella10]

this is how it may look like

[denschub]

Not sure how accurate your mockup is, but some notes: The placement is good, but we already do have icons for messages and mentions on a user's profile page, which we should re-use.

It also looks like you are developing on a stable pod, which you shouldn't do. Please use the develop sources, since a lot of stuff has changed!

[goobertron]

Nice start, @angerella10 - thanks!
In addition to Dennis's comments, I'd suggest not having any border around the new icons. This will save space and keep a 'cleaner' look for the hovercard.

There's also the question what to do when a long aspect name is selected, or if the translation of 'In 2 aspects' is long in the user's locale. I'm not sure how the hovercards deal with this - I think they just expand to the right - but @denschub and @svbergerem would be best to advise here.

Here's my quick mock-up:

We could even potentially add the block icon, like so:

although this might make problems for space.

If necessary, we could save space by stacking the icons vertically:

Anyway, thanks for taking on this task. I think it will add useful functionality to diaspora*.

[angerella10]

@denschub @goobertron may i request to divide this feature into two instead of one whole feature. (1)mention (2)message so I would be able to pull a request on the mention icon to hovercards since I'm already done with it.