Dex: check-go-version should support Go 1.10

[jgehrcke]

When using Go 1.10 the scripts/check-go-version script tells me that I should use something more recent than Go 1.8. The RegEx needs to be updated I suppose.

[jgehrcke]

Also, can we maybe not depend on bash there? I can build Dex in a slick alpine Docker container if it were not for scripts/check-go-version's dependency on Bash (yes, I can install bash, but I don't really want to). Do we only need to change the shebang or does the business logic actually use Bashisms? Maybe the whole check-go-version approach can be simplified, today it created probably more problems for me than it was of use :).

[ericchiang]

I'm for just removing the script :)

On Thu, Sep 6, 2018, 8:26 AM Jan-Philip Gehrcke [e-mail]
wrote:

Also, can we maybe not depend on bash there? I can build Dex in an alpine
Docker container if it were not for scripts/check-go-version's dependency
on Bash. Do we only need to change the shebang or does the business logic
actually use Bashisms? Maybe the whole check-go-version approach can be
simplified, today it created probably more problems for me than it was of
use :).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dexidp/dex/issues/1291#issuecomment-419136612, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACO_XYjFwroutJoS13SkMneYTXPynetFks5uYT6OgaJpZM4WdLBR
.