Devise: Syntax error in Ruby 2.5.0

[schneems]

This line gives a syntax error in 2.5.0 from devise/sessions_controller:

  prepend_before_action only: [:create, :destroy] { request.env["devise.skip_timeout"] = true }

Here's the error with Ruby 2.5.0

$ ruby -v
ruby 2.5.0preview1 (2017-10-10 trunk 60153) [x86_64-darwin14]
⛄  2.5.0 🚀  ~/documents/projects/codetriage (master)
$ bin/rails test test/integration/user_session_test.rb:4
DEPRECATION WARNING: ActiveSupport.halt_callback_chains_on_return_false= is deprecated and will be removed in Rails 5.2. (called from <main> at /Users/rschneeman/Documents/projects/codetriage/config/initializers/new_framework_defaults.rb:22)
Run options: --seed 18636

# Running:

E

Error:
UserSessionTest#test_sign_in_screen_renders:
SyntaxError: /Users/rschneeman/.gem/ruby/2.5.0/gems/devise-4.3.0/app/controllers/devise/sessions_controller.rb:5: syntax error, unexpected '{', expecting keyword_end
...ion only: [:create, :destroy] { request.env["devise.skip_tim...
...                              ^
/Users/rschneeman/.gem/ruby/2.5.0/gems/devise-4.3.0/app/controllers/devise/sessions_controller.rb:5: syntax error, unexpected '}', expecting keyword_end
..."devise.skip_timeout"] = true }
...                              ^
    test/integration/user_session_test.rb:5:in `block in <class:UserSessionTest>'


bin/rails test test/integration/user_session_test.rb:4



Finished in 0.142361s, 7.0244 runs/s, 0.0000 assertions/s.
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
⛄  2.5.0 🚀  ~/documents/projects/codetriage (master)

Works fine with Ruby 2.4.2

$ ruby -v
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin14]
⛄  2.4.2 🚀  ~/documents/projects/codetriage (master)
$ bin/rails test test/integration/user_session_test.rb:4
DEPRECATION WARNING: ActiveSupport.halt_callback_chains_on_return_false= is deprecated and will be removed in Rails 5.2. (called from <main> at /Users/rschneeman/Documents/projects/codetriage/config/initializers/new_framework_defaults.rb:22)
Run options: --seed 54612

# Running:

.

Finished in 0.349041s, 2.8650 runs/s, 2.8650 assertions/s.
1 runs, 1 assertions, 0 failures, 0 errors, 0 skips

[schneems]

Looks like it's fixed in master. Can you cut a new release?

[tegon]

Great! We will make a new version when we have more things to release.
Since this is a preview version of Ruby, we don't need to hurry. If you want to use it already, please change your Gemfile to grab devise from GitHub.

Thank you!

[lucascaton]

hi @tegon - Ruby 2.5 has been released.
Could you please release a new version of Devise?
Thank you.

[tegon]

@lucascaton version 4.4.0 released with the fix.

[schneems]

Thanks!