Detox: detox test crash w/ Signal 6 in release mode

[doronpr]

Description

Detox crashes after running in release mode.

Steps to Reproduce

Detox, Node, Device, Xcode and macOS Versions

• Detox: 7.3.4
• React Native: 0.51.600
• Node: 8.9.1
• Device: iPhone8 Plus Simulator
• Xcode: 9
• macOS: 10.13.3

Device and verbose Detox logs

detox ERR! App crashed in test 'undefined', here's the native stack trace: detox ERR! Signal 6 was raised detox ERR! ( detox ERR! 0 Detox 0x000000010ce2550f _ZL16__DTXHandleCrashP11NSExceptionP8NSNumberP8NSString + 469 detox ERR! 1 Detox 0x000000010ce252bb _ZL17__DTXHandleSignali + 54 detox ERR! 2 libsystem_platform.dylib 0x00000001145ebf5a _sigtramp + 26 detox ERR! 3 ??? 0x000000000000ffff 0x0 + 65535 detox ERR! 4 libsystem_c.dylib 0x00000001142810eb abort + 127 detox ERR! 5 libsystem_malloc.dylib 0x00000001143bbf42 malloc_zone_malloc + 0 detox ERR! 6 Foundation 0x000000010cfaecbc -[NSConcreteMapTable grow] + 938 detox ERR! 7 Foundation 0x000000010cfad258 -[NSConcreteMapTable setObject:forKey:] + 164 detox ERR! 8 Detox 0x000000010ce1c655 -[GREYAppStateTracker(PrettyPrint) _pp__trackState:forObject:] + 144 detox ERR! 9 EarlGrey 0x00000001254903cd -[__NSCFLocalDataTask_GREYAdditions grey_track] + 157 detox ERR! 10 EarlGrey 0x0000000125490752 -[__NSCFLocalDataTask_GREYAdditions greyswizzled_resume] + 210 detox ERR! 11 Inbox 0x000000010ca5092b -[RCTHTTPRequestHandler sendRequest:withDelegate:] + 670 detox ERR! 12 Inbox 0x000000010ca48fb3 -[RCTNetworkTask start] + 149 detox ERR! 13 Inbox 0x000000010ca4eb2d -[RCTNetworking sendRequest:responseType:incrementalUpdates:responseSender:] + 1254 detox ERR! 14 Inbox 0x000000010ca4ff08 __44-[RCTNetworking sendRequest:responseSender:]_block_invoke + 212 detox ERR! 15 EarlGrey 0x00000001254595c4 __60-[GREYDispatchQueueTracker grey_dispatchAsyncCallWithBlock:]_block_invoke + 36 detox ERR! 16 libdispatch.dylib 0x0000000114139177 _dispatch_call_block_and_release + 12 detox ERR! 17 libdispatch.dylib 0x000000011413a1ba _dispatch_client_callout + 8 detox ERR! 18 libdispatch.dylib 0x0000000114141d3d _dispatch_queue_serial_drain + 654 detox ERR! 19 libdispatch.dylib 0x00000001141425a0 _dispatch_queue_invoke + 329 detox ERR! 20 libdispatch.dylib 0x000000011413ec97 _dispatch_queue_override_invoke + 477 detox ERR! 21 libdispatch.dylib 0x0000000114144980 _dispatch_root_queue_drain + 568 detox ERR! 22 libdispatch.dylib 0x00000001141446ea _dispatch_worker_thread3 + 119 detox ERR! 23 libsystem_pthread.dylib 0x00000001145fd1ca _pthread_wqthread + 1387 detox ERR! 24 libsystem_pthread.dylib 0x00000001145fcc4d start_wqthread + 13 detox ERR! )

[LeoNatan]

Thanks
This appears iOS related, it's crashing in the NSMapTable internals. Not sure yet why.

[LeoNatan]

Could be related to thread safety. NSMapTable is not thread safe, so that could be the cause.

[doronpr]

That would make a lot of sense since it only happens in Release mode when the app responds significantly faster and perhaps triggering a race condition. What can we do about it?

[LeoNatan]

I will push a proposed fix soon, and @rotemmiz will release a new version. Let's see if my solution helps.

[LeoNatan]

@rotemmiz Please release a new patch version. Thanks

[LeoNatan]

@doronpr Please update on the status when you can. If my solution didn't work, I will reopen the issue.

[doronpr]

Solved. Thanks @LeoNatan !