Desktop: Staging not used

Created on 3 May 2018 · 3Comments · Source: desktop/desktop

Description

This might be a linux issue, as I have only tried GD on Ubuntu.
I often use my graphical GIT client in conjunction with the command line client. Therefore I use the staging area between them, but it doesn't seem like GitHub Desktop uses the staging area.

Version

GitHub Desktop: GitHubDesktop-linux-amd64-1.1.1
Operating system: Ubuntu 16.04

Steps to Reproduce

Open GitHub Desktop
Make sure something is selected for commit
Check that it it staged with another git client (e.g. git status from command line)

Expected Behavior

Changes selected in GitHub Desktop show up as selected for commit in alternative client.

Actual Behavior

Selected changes in GitHub Desktop does not sync with staging.

Logs

2018-05-03.desktop.production.log

Source

beruic

Most helpful comment

I find that odd since SourceTree and GitKraken both do this. I'd suspect they parse the output of git diff --cached and emulate or use git add -p.

Will you at least make Desktop remember the state when it is shut down, so you can shut it down and continue working on a commit after opening it up again?

beruic on 4 May 2018

👍2

All 3 comments

It’s the same across all platforms by design, see the replies to #4475. 🙂

JordanMussi on 3 May 2018

👍1

@beruic Yep, basically what @JordanMussi said. We want to ensure we interop nicely with other tools, but keeping the checkbox state in sync with the git index is really tricky in some areas like partial commits, which is an important part of Desktop.

shiftkey on 3 May 2018

😕1

I find that odd since SourceTree and GitKraken both do this. I'd suspect they parse the output of git diff --cached and emulate or use git add -p.

Will you at least make Desktop remember the state when it is shut down, so you can shut it down and continue working on a commit after opening it up again?

beruic on 4 May 2018

👍2

Was this page helpful?

0 / 5 - 0 ratings