Desktop: Empty `View on GitHub` placeholder showing on right-click

Created on 5 Sep 2017  ·  3Comments  ·  Source: desktop/desktop

When right-clicking a commit in History for an unpublished repo, the menu options include an empty placeholder for the View on GitHub.

As the commit is still pending, the UI for this option should be adjusted.

screen shot 2017-09-05 at 10 34 38 am

Additionally, should SHA option be shown as well?

bug

All 3 comments

Putting this in 1.0 👍

Additionally, should SHA option be shown as well?

I'm not sure I understand the question?

@joshaber Sorry, I meant to say, should the Copy SHA in the pic still be visible if repo is unpublished?

Oh yeah, that's fine. The SHA is meaningful still.

Was this page helpful?
0 / 5 - 0 ratings