Desktop: validate commit summary to handle whitespace being entered

Created on 16 May 2017  ·  3Comments  ·  Source: desktop/desktop

Description

You can try and create a commit with an empty summary field. It fails.

Version

What version of GitHub Desktop are you running? This is displayed under the
About GitHub Desktop menu item. If you are running from source, include
the commit by running git rev-parse HEAD from your local repository.

GitHub Desktop version: 0.5.1

OS version: Windows 10

Steps to Reproduce

  1. Create a new local repository, pre-populated with some files.
  2. Launch Repository -> Open in Explorer to get to the filesystem
  3. Modify a file so some changes appear in the app
  4. Enter a space for the commit summary

Expected behaviour: A warning that the commit summary is not valid

Actual behaviour: No error

Reproduces how often: 100%

Additional Information

Currently this fails with a somewhat meaningful error, so this feels more like a polish task

There's also some design work here that we'd need to consider given how the commit form is limited.

enhancement help wanted

All 3 comments

Moving this to help wanted as this is something good for an external contributor, but much like #5240 there will probably be some discussion about what makes sense here.

I believe that this issue can be closed now that #5677 has been merged.
I likely should have used "Fixes #1485" for this case.

@Daniel-McCarthy good catch! thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Draco18s picture Draco18s  ·  3Comments

varkor picture varkor  ·  3Comments

AgbajeMike picture AgbajeMike  ·  3Comments

patrickdark picture patrickdark  ·  3Comments

MarcusJohnson91 picture MarcusJohnson91  ·  3Comments