Dependabot-core: Mentions in Changelog send notifications

Created on 2 Oct 2019  路  5Comments  路  Source: dependabot/dependabot-core

Seems to be a recurrence of #427 except for Changelog summary. As an example this PR https://github.com/rdohms/chainlink/pull/36 mentions me in the Changelog section and I got notified about it

All 5 comments

@jrjohnson yes will take a look at fixing this!

Curiously, only the first part of the string up to the first code fence (```registerLoader```) seems to have been sanitized (see the body element in https://api.github.com/repos/rdohms/chainlink/issues/36). This seems to point to a bug in the logic in sanitize_links_and_mentions, where instead of iterating through all the code fences, it considers everything after the start of the first code fence to be part of the code fence, and therefore ingests it as-is.

I've added a couple of tests in my fork that demonstrate the bug. If I have some spare time I'll take a look into fixing the implementation.

@PombeirP yup nice find, I've got a fix here: https://github.com/dependabot/dependabot-core/pull/1426

Thanks @feelepxyz! I'll create a separate PR to handle an additional scenario with complex nested code fences too, to avoid false positives.

Thank you!

Was this page helpful?
0 / 5 - 0 ratings