Dependabot-core: Handle submodule updates when creating GitLab PRs

[deivid-rodriguez]

Hi @greysteil!

I'm having a problem when updating submodules, not sure if I'm doing anything wrong. In this PR, the submodule is being updated to a commit reference that I don't think it exists in the target repository? The submodule referenced in the diff should match the "target_reference" in the PR title ("Bump from <source_reference> to <target_reference>"), I think.

Not sure if the fact that I'm using "dependabot-script" to update itself might be a factor here, and whether the issue could be actually there and not in dependabot-core?

[greysteil]

That... looks really weird. Let me take a closer look.

[deivid-rodriguez]

Thanks! :heart:

[greysteil]

Ah, this is a problem with GitLab. Their API doesn't support pushing updated submodules (see https://gitlab.com/gitlab-org/gitlab-ce/issues/41213). I'm slightly amazed the script didn't blow up here - there's a note in Dependabot Core that submodules for GitLab are a TODO (here) and I wasn't expecting the script to be successful at updating them.

I'll have a dig to see if there's any workaround here.

[deivid-rodriguez]

I see! Thanks @greysteil! Watching the Gitlab issue :)

[deivid-rodriguez]

Related gitlab issue got closed, apparently!

[greysteil]

I saw! Looks like they've implemented some entirely separate API for it 🤦‍♂️.

We need to wait for 11.5 to be released, but once that's out we should be able to get this closed 🎉

[connorshea]

11.5 is out now, fyi

[connorshea]

and now it's supported in the master branch of the gitlab gem :) https://github.com/NARKOZ/gitlab/pull/450

[greysteil]

Fixed in https://github.com/dependabot/dependabot-core/commit/7b5e933097a63660c46cc529c0f54ed8c205a95d 🎉

Thanks for everyone's help on this one. Can one of you verify that everything works as expected? I've just released v0.86.20, which includes that commit.