Dep: Prefetch direct dependencies during init

Created on 9 Sep 2017  路  2Comments  路  Source: golang/dep

The initial caching of the repositories can be slow, and doesn't print any output because it's happening as a side-effect of the other init logic. We used to explicitly prefetch the repositories and log a message, but that was lost at some point over the past months.

https://github.com/golang/dep/pull/194/files#diff-b14a2eb16f1efbc6aa9f1ffdad724265R241

Let's start doing this again during init (most likely in getDirectDependencies), and cap the concurrency at 4.

Original comment that inspired this issue: https://github.com/golang/dep/issues/1129#issuecomment-327533935.

help wanted init

Most helpful comment

@carolynvs I can pick this up. I worked on the original log message story after all 馃槃

All 2 comments

note that an impl of this should almost certainly use golang.org/x/sync/errgroup, which we'll be introducing in #1155

@carolynvs I can pick this up. I worked on the original log message story after all 馃槃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jeffwillette picture jeffwillette  路  3Comments

abeMedia picture abeMedia  路  3Comments

rustyx picture rustyx  路  3Comments

tapir picture tapir  路  3Comments

deejross picture deejross  路  3Comments