Dep: Should users manually edit Gopkg.toml when adding a dependency?

[F21]

The instructions say that when adding a dependency, we should import the code and run dep ensure.

Should we edit Gopkg.toml to include the new dependency as well?

[sdboyer]

@F21 that's one acceptable path, but things are a bit different now, with the introduction of dep ensure -add. that's probably going to be an easier path for most people, most of the time.

i will update the README tonight 😄

[F21]

I just added a dependency using dep ensure -add github.com/someorg/someproject/somepkg, but while Gopkg.lock was updated, the dependency was not added to Gopkg.toml.

In my case, I was trying to add github.com/someorg/someproject/somepkg, since someproject did not have any Go code in the repository's root. However, Gopkg.lock was updated correctly to import github.com/someorg/someproject with the relevant tag.

[sdboyer]

Yep, you're right in this hole. when that branch is implemented, it'll pick a constraint and append it into Gopkg.toml based on the version that was selected for Gopkg.lock.

i considered waiting to merge #489 for it, but i decided to defer it, as things had already taken so long.

this reminds me, though, that it should probably be one of our highest priority things on ensure right now /cc @ibrasho

[F21]

Oh, cool. That makes sense! 😄 Hope that makes it into dep soon. Other than that, dep has been working super well for us 👍

[ibrasho]

994 is merged so this should be closed now. :+1:

[F21]

Thanks @sdboyer !