Dep: Consolidate fs.go, internal/fs.go, and gps/internal/fs/fs.go

Created on 10 May 2017  路  5Comments  路  Source: golang/dep

fs.go and gps/internal/fs/fs.go contain a lot of duplicate code, back from when they were completely separate projects. They should be consolidated into a single internal/fs subpackage.

While we're at it, let's also rearrange internal/fs.go into the same internal/fs subpackage.

help wanted good first issue

All 5 comments

Note - this will break gps' encapsulation, as it'll be reaching up into github.com/golang/dep/internal/fs for these functions. In general, I want to keep that encapsulation intact, but it's OK to make an exception here for these functions, which are likely to always remain internal, and that we really _don't_ want to duplicate.

I can take this up @sdboyer

@vedhavyas woohoo, awesome! though looks like @ibrasho may have beat you to it - but we've got issues popping out left and right currently, i'm sure there'll be another one coming up soon 馃槃

now that #547 is closed should this ticket be closed?

ah yes, thanks!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jiharal picture jiharal  路  3Comments

rogpeppe picture rogpeppe  路  4Comments

jjyr picture jjyr  路  3Comments

deejross picture deejross  路  3Comments

cemremengu picture cemremengu  路  3Comments