Dep: remove the "cute" error messages

Created on 25 Jan 2017  路  4Comments  路  Source: golang/dep

fmt.Printf("ouchie, solve error: %s", err)

Go tools have a specific tone and style (simple comprehensive and precise), hence we don't see them return errors in such an unlikely style. Follow the Go tool conventions, please. This is a candidate to be an official tool.

enhancement

Most helpful comment

Oh, of course. The places where we don't follow that convention, like the one you've cited, exist more or less because it gives the clear indication that it's an area that is unfinished. There's no way we'd let them into the final tool. (let's not forget - pre-alpha!)

All 4 comments

Oh, of course. The places where we don't follow that convention, like the one you've cited, exist more or less because it gives the clear indication that it's an area that is unfinished. There's no way we'd let them into the final tool. (let's not forget - pre-alpha!)

I can sign up to fix these as I see.

It is good to align with the Go project as soon as possible to making the blessing of this tool or reusing of its code easier if succeeds. It'd be a shame if we had to re-rewrite this tool.

I can sign up to fix these as I see.

馃帀 馃帀

so long as there's a clear TODO (or equivalent) left behind, i'm all 馃憤 to that.

It is good to align with the Go project as soon as possible to making the blessing of this tool or reusing of its code easier if succeeds. It'd be a shame if we had to re-rewrite this tool.

for sure. and, like i noted elsewhere (too many issues flying around right now), this is something that just gets harder as time goes on.

tbh, i'm less concerned about that for this tool than i am for gps. i've put a lot more deliberate effort into it than the parts of dep i've written (which has generally been written with a more experiment/prototyping mindset). still, though, there's likely plenty of style/convention things that i've missed, because i haven't spent the time acculturating to how core reviewers do things.

i think these are pretty much gone now - closing

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jeffwillette picture jeffwillette  路  3Comments

jiharal picture jiharal  路  3Comments

alecthomas picture alecthomas  路  3Comments

mohanraj-r picture mohanraj-r  路  3Comments

tapir picture tapir  路  3Comments