Deno: 2019-06-05 benchmark page isn't being updated

[ry]

commit e152dae seems to have pushed to the gh-pages branch: https://travis-ci.com/denoland/deno/jobs/205789155

commit 2ee2f3efe853e69a4d4913d490e7495a094f82e6
Author: Deployment Bot (from Travis CI) <[email protected]>
Date:   Wed Jun 5 20:48:40 2019 +0000
    Deploy denoland/deno to github.com/denoland/deno.git:gh-pages
 data.json   | 2 +-
 recent.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

and the benchmarks appear to have run correctly.

But it isn't displayed on the page

the last change displayed is a71305b4febc3d8db95d3d144ae3a64c023718f0

The https://denoland.github.io/deno/recent.json file doesn't match what's in the gh-pages branch:

> curl -s https://denoland.github.io/deno/recent.json | shasum
391f0206020d2de2dc8cd1ec86f89a4a6325017e  -
> git checkout 2ee2f3efe853e69a4d4913d490e7495a094f82e6
HEAD is now at 2ee2f3ef Deploy denoland/deno to github.com/denoland/deno.git:gh-pages
> shasum recent.json
fd314de156174ec040da5f0040e0660f7ce2ea5e  recent.json

[ry]

I discovered a warning in the github settings for the project

I have pushed some commits to the gh-pages branch to delete the rustdoc and typedoc symlinks. I'm not sure how they appeared.

This appears to have fixed things.

[ry]

This issue is recurring. I've pushed another "rm typedoc rustdoc" in 7c7b3b0b.

It's unclear to me why these directories are suddenly getting created in gh-pages.

@hayd @bartlomieju Could this be related to the tools/test.py refactor?

[hayd]

I don't think /tools/benchmark.py was modified in tools/test.py change?
https://github.com/denoland/deno/commits/master/tools/benchmark.py

Ah, I wonder if it's there's no spawned server?

I wonder if it should be:

if __name__ == '__main__':
    with http_server.spawn():
        main(sys.argv)

Ooops, my bad for not spotting that!

Edit: Though it does look like the benchmarks page is updating so I'm unclear on this issue.

[hayd]

Actually, I don't see how it can be that.

Perhaps we could add those two files to the .gitignore ? As it seems to still be an issue.

[bartlomieju]

Ooops, missed this issue, I'll check and get back to you

EDIT:
This totally makes no sense but it seems that the problem occurred after landing https://github.com/denoland/deno/commit/0b50c698ad898cd8fbdd1dc21956d584887fd87a which added git command to manual... There were literally no changes touching deployment process whatsoever. I'll add revert PR to check if this fixes the problem.

[ry]

Following @hayd's advice, I've added a gitignore in the gh-pages branch: adb02da
Hopefully that fixes it.

[ry]

Still broke

[ry]

It seems removing the trailing slash from the gitignore fixed it.