Deno: Add style guide for commit messages
Our commit message formatting is all over the place. Now that Deno is a bit more mature we should try to nail this down. Ideally we'd have some sort of lint for commit messages as well (for example, the first line of commit end in a period, CI should reject such messages)
https://golang.org/doc/contribute.html#commit_messages
https://github.com/golang/go/wiki/CommitMessage
ry
All 4 comments
Agreed. Also it would be nice to work on the style guide of Issues and PR using the github templates.
zekth
on 8 Apr 2019
IMHO good for that are commitizen + commitlint.
sh7dm
on 20 Apr 2019
If you’re mainly committing via PRs, I’d suggest instead linting PR titles using a GitHub App instead, since those are much easier to edit and the “squash and merge” feature pretty much obliterates the commit messages anyway. This could work hand-in-hand with requiring CI to pass before merging, effectively blocking commits from being pushed to master directly.
j-f1
on 20 Apr 2019
This has largely been done in the PULL_REQUEST_TEMPLATE.md, though docs/contributing/ could of course be more explicit, but closing for now.
kitsonk
on 5 Nov 2020
Related issues
xueqingxiao
·
3Comments
sh7dm
·
3Comments
kitsonk
·
3Comments
ry
·
3Comments
ry
·
3Comments
Most helpful comment
If you’re mainly committing via PRs, I’d suggest instead linting PR titles using a GitHub App instead, since those are much easier to edit and the “squash and merge” feature pretty much obliterates the commit messages anyway. This could work hand-in-hand with requiring CI to pass before merging, effectively blocking commits from being pushed to
masterdirectly.