Delve: Make install is broken in the master branch for Go < 1.7

[beono]

I had to manually checkout v1.0.0-rc.1 because in the master branch make install doesn't work.

1. What version of Delve are you using (dlv version)?

The latest, dlv version obviously doesn't work.

root@rr3:~/go/src/github.com/derekparker/delve# git log -1
commit 7214ffe20ed70216ab8c8b67efcf4ae62d4a1812
Author: Joey Geiger <[email protected]>
Date:   Fri Jul 21 09:27:41 2017 -0600

1. What version of Go are you using? (go version)?

go version go1.6.2 linux/amd64

1. What operating system and processor architecture are you using?

Linux rr3 4.4.0-83-generic #106-Ubuntu SMP Mon Jun 26 17:54:43 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

1. What did you do?

root@rr3:~# git clone https://github.com/derekparker/delve
Cloning into 'delve'...
remote: Counting objects: 9819, done.
remote: Compressing objects: 100% (25/25), done.
remote: Total 9819 (delta 23), reused 36 (delta 20), pack-reused 9774
Receiving objects: 100% (9819/9819), 11.69 MiB | 0 bytes/s, done.
Resolving deltas: 100% (6100/6100), done.
Checking connectivity... done.
root@rr3:~# cd delve/
root@rr3:~/delve# make install
go install -ldflags="-X main.Build=7214ffe20ed70216ab8c8b67efcf4ae62d4a1812" github.com/derekparker/delve/cmd/dlv
# github.com/derekparker/delve/pkg/dwarf/reader
pkg/dwarf/reader/variables.go:78: vrdr.dwarf.Ranges undefined (type *dwarf.Data has no field or method Ranges, but does have dwarf.ranges)
Makefile:49: recipe for target 'install' failed
make: *** [install] Error 2

1. What did you expect to see?
   A succesful message

2. What did you see instead?

root@rr3:~/go/src/github.com/derekparker/delve# make install
go install -ldflags="-X main.Build=7214ffe20ed70216ab8c8b67efcf4ae62d4a1812" github.com/derekparker/delve/cmd/dlv
# github.com/derekparker/delve/pkg/dwarf/reader
pkg/dwarf/reader/variables.go:78: vrdr.dwarf.Ranges undefined (type *dwarf.Data has no field or method Ranges, but does have dwarf.ranges)
Makefile:49: recipe for target 'install' failed
make: *** [install] Error 2

[catkins]

We're also seeing this with go get

go get -u -v github.com/derekparker/delve/cmd/dlv
github.com/derekparker/delve (download)
github.com/derekparker/delve/pkg/dwarf/util
github.com/derekparker/delve/vendor/golang.org/x/arch/x86/x86asm
github.com/derekparker/delve/vendor/golang.org/x/sys/unix
github.com/derekparker/delve/vendor/github.com/peterh/liner
github.com/derekparker/delve/pkg/version
github.com/derekparker/delve/vendor/gopkg.in/yaml.v2
github.com/derekparker/delve/pkg/goversion
github.com/derekparker/delve/vendor/github.com/spf13/pflag
github.com/derekparker/delve/pkg/dwarf/op
github.com/derekparker/delve/pkg/dwarf/frame
github.com/derekparker/delve/pkg/dwarf/line
github.com/derekparker/delve/pkg/dwarf/godwarf
github.com/derekparker/delve/pkg/dwarf/reader
# github.com/derekparker/delve/pkg/dwarf/reader
../../derekparker/delve/pkg/dwarf/reader/variables.go:78: vrdr.dwarf.Ranges undefined (type *dwarf.Data has no field or method Ranges, but does have dwarf.ranges)
github.com/derekparker/delve/vendor/github.com/spf13/cobra
github.com/derekparker/delve/pkg/config

[catkins]

it seems to be working on [email protected] but not [email protected] (the two versions I have installed)

[catkins]

Looks like #824 introduced a change which requires go 1.7 or higher

[beono]

The documentation says delve works on go 1.5 and higher. https://github.com/derekparker/delve/tree/master/Documentation/installation

[justinclift]

Sounds like this should be closed now, and the issue title updated to mention something like "for Go < 1.7". :smile:

[derekparker]

Closing this, docs have been updated.