Current state:
$ tree conversations/
conversations/
โโโ build
โย ย โโโ manifest.css
โโโ stylesheets
โโโ _conversation.scss
โโโ _debugLog.scss
โโโ _emoji.scss
โโโ _global.scss
โโโ _index.scss
โโโ _lightbox.scss
โโโ manifest.scss
โโโ _mixins.scss
โโโ _modal.scss
โโโ _modules.scss
โโโ _options.scss
โโโ _progress.scss
โโโ _recorder.scss
โโโ _settings.scss
โโโ _variables.scss
I propose we change it to:
$ tree css/
css/
โโโ _conversation.scss
โโโ _debugLog.scss
โโโ _emoji.scss
โโโ _global.scss
โโโ _index.scss
โโโ _lightbox.scss
โโโ manifest.scss
โโโ _mixins.scss
โโโ _modal.scss
โโโ _modules.scss
โโโ _options.scss
โโโ _progress.scss
โโโ _recorder.scss
โโโ _settings.scss
โโโ _variables.scss
Also, we should change the output file from conversations/build/manifest.css to e.g. static/manifest.css.
Another thing that I was wondering about, is why we load manifest.css using insert-css:
Why can't we just load it like any other css files from main.html?
We also should think about removing usused css and starting with #409 while were already at it
We also should think about removing usused css and starting with #409 while were already at it
this might be hard as we can't really be sure if we need that css stuff or not depending on how good conversations was modularized. Maybe there are some tree shaking tools for css, but don't know much about that.
I would propose another folder structure where we have all conversations related scss stuff in a own folder.
$ tree css/
css/
โโโ conversations
โโโ _conversation.scss
โโโ _debugLog.scss
โโโ _emoji.scss
โโโ _global.scss
โโโ _index.scss
โโโ _lightbox.scss
โโโ manifest.scss
โโโ _mixins.scss
โโโ _modal.scss
โโโ _modules.scss
โโโ _options.scss
โโโ _progress.scss
โโโ _recorder.scss
โโโ _settings.scss
โโโ _variables.scss
This makes it clear that this is used from src/rendered/components/conversations/*
Most helpful comment
this might be hard as we can't really be sure if we need that css stuff or not depending on how good conversations was modularized. Maybe there are some tree shaking tools for css, but don't know much about that.
I would propose another folder structure where we have all conversations related scss stuff in a own folder.
This makes it clear that this is used from src/rendered/components/conversations/*