Definitelytyped: Outdated types on mui-datatables

[hugobarragon]

Missing alot of types on mui-datatables package

https://github.com/gregnb/mui-datatables#options
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/mui-datatables/index.d.ts#L162
for example : confirmFilters and customFilterDialogFooter and the table state to with sortOrder

MUIDataTableState missing options versus normal tableState

Definitions by: Jeroen "Favna" Claassens @Favna https://github.com/favna
// Ankith Konda @ankithkonda https://github.com/ankithkonda
// Herman "Von" Waters IV @hwatersiv https://github.com/hwatersiv
// souppower @souppower https://github.com/souppower
// Byron "Byrekt" Mitchell @byrekt https://github.com/byrekt

[Favna]

If the maintainers of this repo would ever merge my PR they would get added https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45306

But despite asking for it multiple times on Gitter and mentioning them on the PR they are completely non-responsive.

[hugobarragon]

If the maintainers of this repo would ever merge my PR they would get added #45306

But despite asking for it multiple times on Gitter and mentioning them on the PR they are completely non-responsive.

Now that we have and issue maybe it goes through, nice one man, thanks for the PR, I didnt know there was one already 👍 lets see what happens. 👀

[peterblazejewicz]

fixed in #45306

[hugobarragon]

@peterblazejewicz already updated, but on MUIDataTableState sortOrder still missing, check my table state prinst screen.
i counted, and there are 4 missing props on the tableState
columnOrder
previousSelectedRow
searchProps
sortOrder

export interface MUIDataTableState {
    activeColumn: string | null;
    announceText: string | null;
    columns: MUIDataTableColumnState[];
    count: number;
    data: any[];
    displayData: Array<{ dataIndex: number; data: any[] }>;
    expandedRows: MUIDataTableStateRows;
    filterData: any[];
    filterList: string[][];
    page: number;
    rowsPerPage: number;
    rowsPerPageOptions: number[];
    searchText: string | null;
    selectedRows: MUIDataTableStateRows;
    showResponsive: boolean;
}

[Favna]

Oh I see what the core of the problem is here, those properties are on MUIDataTableOptions but not MUIDataTableState. The reason for this is because I followed the migration documentation and the README doesn't properly document the type of the table state (like, it's not there at all)

From the README on onTableChange:

Callback function that triggers when table state has changed. function(action: string, tableState: object) => void

And there is no documentation on the type of tableState siigh

And from the migration guide:

sortDirection deprecated in favor of sortOrder

The sort direction of the table is now controlled by options.sortOrder (example). Using a sortDirection value on a column's options object will still work, but it will print a >? > deprecation notice when run in development mode.

More information here: gregnb/mui-datatables/pull/1310

---

Can you create a pull request to add these types? At least that way I'll approve it (once all good of course) and as the bot will automate the process then it won't be another month before your changes will land.

[hugobarragon]

PR here #45981