Definitelytyped: typesVersions gets mangled in the published package

Created on 22 Apr 2020  路  8Comments  路  Source: DefinitelyTyped/DefinitelyTyped

Most helpful comment

@rbuckton points out that dtslint currently requires one-sided ranges like >=3.1 but should actually require two-sided ranges for all but one of the typesVersions entries. That way order would not matter.

(I'm going to fix the re-ordering first, but changing the range lint check is definitely better long-term.)

All 8 comments

@sandersn:

This seems to be a general problem (not node-typings specific) in the publishing process, as e.g. the jsdom typings have the same problem. Compare https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/jsdom/package.json vs. https://unpkg.com/@types/jsdom@16.2.1/package.json.

Hey look its me!

~This could maybe be the cause of #44142 馃~ false alarm, it's not 馃檪

Can confirm that this does mean the new asserts guards can't be used :(

Looks like I can't transfer issues across orgs :angry: I created microsoft/types-publisher#772 to track this.

@sandersn Okay cool. Thx

@rbuckton points out that dtslint currently requires one-sided ranges like >=3.1 but should actually require two-sided ranges for all but one of the typesVersions entries. That way order would not matter.

(I'm going to fix the re-ordering first, but changing the range lint check is definitely better long-term.)

It seems like the reordering is fixed, at least for @types/node.

https://unpkg.com/@types/node@13.13.5/package.json

@sandersn Can we close this issue?

Yep!

Was this page helpful?
0 / 5 - 0 ratings