Definitelytyped: Breaking change in @3.2.5

Created on 27 Dec 2019  路  2Comments  路  Source: DefinitelyTyped/DefinitelyTyped

If you know how to fix the issue, make a pull request instead.

I tried using the @types/[email protected] package and had problems.
Seems there is breaking change 3.2.4 to 3.2.5,
This code snippet changed FROM
declare namespace compose { type Middleware<T> = (context: T, next: () => Promise<any>) => any; type ComposedMiddleware<T> = (context: T, next?: () => Promise<any>) => Promise<void>; }
TO
declare namespace compose { type Middleware<T> = (context: T, next: Koa.Next) => any; type ComposedMiddleware<T> = (context: T, next?: Koa.Next) => Promise<void>; }
Return type of next is changed.

Can we please bump it in a nice manner so that it does introduce any breaking change.
@maxdeviant @phobon @zephraph @damassi @alloy @maoueh @Lavoaster @jschuler @adam187 @gretzky @chrislopresto @peduarte

Most helpful comment

Types versions major numbers match their packages and are not semvered

All 2 comments

I鈥檓 unsure why you tagged us, the maintainers of Koa-compose are @jkeylu & @astashov and that change seems to have been made by @thewilkybarkid on https://github.com/DefinitelyTyped/DefinitelyTyped/pull/40213.

Types versions major numbers match their packages and are not semvered

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jamespero picture jamespero  路  3Comments

fasatrix picture fasatrix  路  3Comments

alisabzevari picture alisabzevari  路  3Comments

JWT
svipas picture svipas  路  3Comments

JudeAlquiza picture JudeAlquiza  路  3Comments