Definitelytyped: Export this type

[braxtonc]

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/354cec620daccfa0ad167ba046651fb5fef69e8a/types/p-defer/index.d.ts#L6

I'd love to see this interface exported.

[LoganDark]

Then make a pull request, literally adding 7 characters (export plus a space)

[braxtonc]

Wasn't sure what contribution rules there were. Other projects prefer to discuss issues before work is started I'll make the PR tonight.

Sent from my T-Mobile 4G LTE Device

-------- Original message --------
From: LoganDark [e-mail]
Date: 5/29/18 6:42 PM (GMT-07:00)
To: DefinitelyTyped/DefinitelyTyped [e-mail]
Cc: Braxton Christensen [e-mail], Author [e-mail]
Subject: Re: [DefinitelyTyped/DefinitelyTyped] Export this type (#26116)

Then make a pull request, literally adding 7 characters (export plus a space)

-
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_DefinitelyTyped_DefinitelyTyped_issues_26116-23issuecomment-2D392993953&d=DwMCaQ&c=pfK1XwE45S3CTx_UtKM9kg&r=1ai0j1Q-RYCoHvGSowmphRDuH9IBNRzIGBZY0QjrgRQ&m=c1eX3jZJABHiut5j9gz9ldRqDxZRmeBzPoG3kNy7aVg&s=Y0oa6PzKsnPZGcpnsnDBg4Om5V8a_L5UFr52R6bmFAI&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Abj-5FI1LgF5JXHhfg-5F89-2Di-5FzqMNYycXGRks5t3esMgaJpZM4USEDJ&d=DwMCaQ&c=pfK1XwE45S3CTx_UtKM9kg&r=1ai0j1Q-RYCoHvGSowmphRDuH9IBNRzIGBZY0QjrgRQ&m=c1eX3jZJABHiut5j9gz9ldRqDxZRmeBzPoG3kNy7aVg&s=u37DD7WOYkTAUvI05A0jkw3-NZdkAapeDf2xziC-edo&e=.

[LoganDark]

This isn't an issue that exactly needs to be discussed. If you need to use that type, we need to export it. It's pretty simple and easy to understand why you'd make the PR.

[andnp]

This may be of interest

[LoganDark]

Your comment in a nutshell:

Then make a pull request, literally adding 7 characters (export plus a space)

Which is my comment I posted about a week ago.

[andnp]

I had hoped that my comment was of a little more value than that.

---

In general, your comments (including #26098) are coming across as snarky and aggressive. Your message is consistent: "you should contribute to this codebase!"; a message with which I wholeheartedly agree. I think you would be much better received with gentler responses that do not scare away new contributors but instead provide them with the tools necessary to contribute (for instance providing links to the contribution guide).

[LoganDark]

I'm sorry if my comments seem snarky or aggressive. I guess some other people are rubbing off on me...

[braxtonchristensen]

This was actually solved before I could open a PR thanks for the help @andnp this issue can be closed since this has been merged in #25917