Deepreg: Config files in demos potentially incorrect for the new registry

Created on 15 Jan 2021  路  4Comments  路  Source: DeepRegNet/DeepReg

Subject of the issue

We are in the process of updating the config files for the back compatibility change for 1.0.0 given the change to registry method.

As raised in this discussion we are moving away from the old config file style, into the new config file style.

Looking for examples to update the docs, I noted that the demos may be broken because the config files no longer follow the correct order: "name" then arguments versus "backbone" then arguments.

Files with incorrect configs:

bug config demo docs priority question

All 4 comments

Sorry, @NMontanaBrown @YipengHu the demo tests are passed, what is the problem here :) ?

Sorry, @NMontanaBrown @YipengHu the demo tests are passed, what is the problem here :) ?

I'm not 100% sure as have not looked in details myself. Suggest to look at #624 first as an example for this "potential" issue.

So I guess we can close this issue? @NMontanaBrown as all demos train/predict have been tested with CI, configs should be correct.

Yes, thanks @mathpluscode closing now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

YipengHu picture YipengHu  路  6Comments

mathpluscode picture mathpluscode  路  6Comments

NMontanaBrown picture NMontanaBrown  路  6Comments

mathpluscode picture mathpluscode  路  3Comments

NMontanaBrown picture NMontanaBrown  路  4Comments