Deepreg: Identify all code not covered by unit-test or non-independent

Created on 31 Aug 2020  路  6Comments  路  Source: DeepRegNet/DeepReg

Subject of the code / test

We are almost 100% test coverage, need to identify all pieces of code not covered by tests with the help of codecov.
Also, we need to identify the test codes that need to be refactored, namely those tests placed sequentially inside one function and those can be simplified using parameterize.

test

Most helpful comment

@NMontanaBrown We now only have 11 lines not covered, we can choose to cover then or ignore them. Ignoring some is acceptable for me.

cc @YipengHu @zacbaum ^^

no comment

All 6 comments

@NMontanaBrown can you review this and maybe an estimate of time required?

I am back from the dead, I will be reviewing this week, raising issues, and reporting at meeting on Thursday 馃槃

@NMontanaBrown We now only have 11 lines not covered, we can choose to cover then or ignore them. Ignoring some is acceptable for me.

cc @YipengHu @zacbaum ^^

@NMontanaBrown We now only have 11 lines not covered, we can choose to cover then or ignore them. Ignoring some is acceptable for me.

cc @YipengHu @zacbaum ^^

no comment

^^ I'd like to just push to 100% coverage

I'm fine with ignoring some which aren't possible to cover by ourselves (e.g. which rely on testing from external libraries - I've seen some calls to Keras Model. be flagged as not covered) - just a matter of seeing which remain after that.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mathpluscode picture mathpluscode  路  3Comments

NMontanaBrown picture NMontanaBrown  路  5Comments

NMontanaBrown picture NMontanaBrown  路  5Comments

s-sd picture s-sd  路  3Comments

mathpluscode picture mathpluscode  路  6Comments