Unit tests for unpaired_laoder, in pytest style.
Please delete options that are not relevant.
Unit tests for class methods, lint and docs.
@acasamitjana @NMontanaBrown
I'd like to add some suggestions on how can we test this class, as I'm not sure it's obvious.
What we can do is to
UnpairedDataLoader instance, using a toy config, check test_unpaired_labeled.py for examplevalidate_Data_files by asserting it returns None as in case of errors, the return won't be Nonesample_index_generator, we can get one return and check output types, it should be int, int, list of two intsclose i don't know, i suggest to skip it, @NMontanaBrown what do you thinkTo be safe, it might be better to test for both nifti and h5 file loaders
btw, i had some typos in sample_index_generator,
Hi @acasamitjana @mathpluscode, if any doubts please confer with @s-sd or refer to their tests - q thorough, close to 100%/100% coverage! They should allow for more clarity, if any doubts feel free to ping me 馃槃
@acasamitjana i believe @NMontanaBrown means this issue #125 !
I don't follow you now. What do you mean?
@acasamitjana oh l just link @s-sd 's issue as i thought @NMontanaBrown said it's an example of good testing. Nothing else ;)
Most helpful comment
Hi @acasamitjana @mathpluscode, if any doubts please confer with @s-sd or refer to their tests - q thorough, close to 100%/100% coverage! They should allow for more clarity, if any doubts feel free to ping me 馃槃