Deeplearning4j: Type inconsistency

Created on 5 Mar 2019  路  4Comments  路  Source: eclipse/deeplearning4j

Issue Description

I am using rldj for some experiments, but I found type inconsistency between rl4j and nd4j. The return type of INDArray's shape() is long[]锛宐ut the parameter type Learning.makeShape() needed is int[].

Version Information

Rl4j and nd4j are all 1.0.0-SNAPSHOT.

360 20190305090135007
360 20190305090512291

Aha! Link: https://skymindai.aha.io/features/ND4J-43

Bug RL4J

Most helpful comment

Yes, in the sense that we could in theory need to have dimensions larger than Integer.MAX_VALUE.

I got it and will send a pull request later.

All 4 comments

Please feel free to update it to long[] and send a pull request! Thanks for reporting

Please feel free to update it to long[] and send a pull request! Thanks for reporting

In other words, this is a bug?

Yes, in the sense that we could in theory need to have dimensions larger than Integer.MAX_VALUE.

Yes, in the sense that we could in theory need to have dimensions larger than Integer.MAX_VALUE.

I got it and will send a pull request later.

Was this page helpful?
0 / 5 - 0 ratings