@bangerth This should have been issue number 10000 :smile_cat:
Do we want to increment to 10.0.0 after this release? We discussed this on the call today and, if I recall correctly, no one explicitly opposed it.
Ha, yes, that would have deserved the 10,000!
I wasn't on the call at that point (sorry, guys) but once we bump to 10.0.pre, you can't go back to 9.3.pre any more if we decide that the next release isn't worth the major version number upgrade. My preference would be to stick with the 9.x scheme unless we have a good reason to actually want a new major version number. (I suspect that you had a good reason -- anyone want to share?)
we have a good reason to actually _want_ a new major version number.
We were chatting about some bigger changes that might happen after this release (merge hp and non-hp dofhandler, bigger linear algebra changes, etc.). This might justify breaking a few things and calling it a new major release.
But I agree, we should bump to 9.3.pre because this allows us to delay this decision.
I can confirm that we now build cleanly with:
Intel 18.0.3.20180410
Intel 19.0.5.20190815
Intel 19.1.0.20200306
I can confirm that we now build cleanly with:
Intel 18.0.3.20180410 Intel 19.0.5.20190815 Intel 19.1.0.20200306
I have just set up 19.1.1.217 on bob. Compilation succeeds - the test
results of the dozen tests I ran scared me. I will enable the variant
for the next test run.
the test results of the dozen tests I ran scared me
Yeah, there have been really scary incorrect optimizations in the past. Do you want to share some to look into?
@tjhei The testsuite (aka bob) should be done in about 8-10h. We will have a detailed testsuite run then.
@tjhei https://cdash.43-1.org/buildSummary.php?buildid=6316 - this doesn't look good. (Also, the whole icc run was more than 8h. For reference, clang manages to finish in 1h 20min.)
Wow, those are some interesting problems. Lots of different stuff!
It is slow because we use ld, I think.
So, something is wrong with your configuration as all MPI related tests fail. On my machine, many of the tests pass (I haven't done a whole run though).
I'm working on the bounding box failure.
@drwells Hold your horses on that one - I think we're good for all sensible compilers.
@tjhei Well then, would you mind to shed some light what "on my machine" precisely means? You did recompile the whole dependency tree with icc?
@dealii/dealii All, I think we reached a very good state to branch off and tag an rc1. I suggest we wait for #7513 (which is reasonably self contained) and we tag afterwards. We can selectively cherry pick to the release branch afterwards. I suggest we extend the "merge window" by one day to Wednesday next week (because we tag one day earlier).
@tamiko Would you prefer that we ignore these failures on the release branch?
(You're right that it's not a big deal - I just want to see what your plan is).
@drwells As @tjhei pointed out the test failures above are very likely at least in part also an issue with the environment in the container (I did install icc into my gcc-8 container and did not check whether the openmpi version installed in the container is actually compatible, etc.). My call is to ignore this test result and tag the rc1 now in order to have a known release candidate that everyone can test individually as well.
@tjhei The build actually uses ld.gold (icc supports that at least in the lastest version). :smile:
Well then, would you mind to shed some light what "on my machine" precisely means?
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 18.04.4 LTS
$ . ~/bin/intel/parallel_studio_xe_2020/psxevars.sh
Intel(R) Parallel Studio XE 2020 Update 1 for Linux*
Copyright (C) 2009-2020 Intel Corporation. All rights reserved.
heister@heister-haidebao ~ $ icpc -v
icpc version 19.1.1.217 (gcc version 7.5.0 compatibility)
$ mpicxx -v
mpicxx for MPICH version 3.3a2
$ g++ -v
gcc version 7.5.0 (Ubuntu 7.5.0-3ubuntu1~18.04)
dependencies compiled with gcc.
@tjhei Merci! (Udate: I have changed the container now to Ubuntu LTS 18.04 with icc. Let's see.)
- [ ] cherry-pick #10161 (Matthias: moved to the top)
VM is updated: https://github.com/tjhei/dealii-vm/releases/tag/v1.19
Wait, who checked "celebration" and celebrated without me? :-)
Thanks, @tamiko and @kronbichler for your hard work over the last couple of weeks!
Most helpful comment
@bangerth This should have been issue number 10000 :smile_cat: