Dd-trace-rb: Wrong distributed headers injection env var is used

Created on 30 Oct 2020  路  2Comments  路  Source: DataDog/dd-trace-rb

I'm finding two permutations of DD_PROPAGATION_STYLE_INJECT string being used throughout the documentation and the code:
A. DD_PROPAGATION_STYLE_INJECT
B. DD_PROPAGATION_INJECT_STYLE

From the Ruby documentation, I expected this library to parse the environment variable in permutation A. However, this library uses permutation B.

Go documentation mentions the use of permutation A which is consistent with the dd-trace-go source code

What do you think about updating the code to use permutation A (that'll be consistent with the documentation and other languages)?

extraction env var uses the wrong ordering as well.

Most helpful comment

馃憢, thank you reporting this issue.

Our documentation is definitely mismatched with our implementation. I believe the correct course of action is to move Ruby to move to DD_PROPAGATION_STYLE_INJECT instead.

I'll double check with our team to find out what the desired environment variable name is.

All 2 comments

馃憢, thank you reporting this issue.

Our documentation is definitely mismatched with our implementation. I believe the correct course of action is to move Ruby to move to DD_PROPAGATION_STYLE_INJECT instead.

I'll double check with our team to find out what the desired environment variable name is.

馃憢 @jumbosushi, we've shipped a fix for this issue in 0.43.0. I'm closing this issue as done.

Please let us now if you still have any feedback on it.

Was this page helpful?
0 / 5 - 0 ratings