Dbt: printer.print_run_result_error should log to warning or error instead of info

Created on 9 Oct 2019  路  3Comments  路  Source: fishtown-analytics/dbt

dbt.ui.printer.print_run_result_error only uses logger.info to display the messages. However, these should be logged at either the error or warning level depending on the is_warning parameter.

bug good first issue
Source
picture heisencoder

Most helpful comment

Coming shortly...

picture heisencoder on 10 Oct 2019
🎉1 👍1

All 3 comments

Hey @heisencoder - I buy that! Feel free to send through a PR for the change if you're so inclined; I'd happily merge it :)

drewbanin picture drewbanin on 10 Oct 2019

Coming shortly...

heisencoder picture heisencoder on 10 Oct 2019
🎉1 👍1

this was fixed in #1823 - thanks @heisencoder! :D

drewbanin picture drewbanin on 17 Oct 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

nave91 picture nave91  路  3Comments
drewbanin picture drewbanin  路  4Comments
drewbanin picture drewbanin  路  3Comments
joellabes picture joellabes  路  3Comments
jtcohen6 picture jtcohen6  路  3Comments