Dayjs: ideas about saving some bytes

[FoxDaxian]

https://github.com/iamkun/dayjs/blob/97763f83fc84ea86ca8a3adb0ada467127a4eb0e/src/utils.js#L27

[iamkun]

Sounds interesting, any detailed information please?

[Imperat]

Good idea to write it in less amount of symbols:

-const isUndefined = s => s === undefined
+const isUndefined = s => s === void 0

[iamkun]

yes, it's shorter than undefined and save a little bytes 😁

[iamkun]

Why closing? @a13821190779

[FoxDaxian]

I thought you probably got it, so. . .

[Imperat]

I had some ideas about saving some bytes.. example:

-return Utils.padStart(this.$H < 13 ? this.$H : this.$H - 12, match === 'hh' ? 2 : 1, '0')
+return Utils.padStart(this.$H < 13 ? this.$H : this.$H - 12, match.length, '0')

Let me investigate it when I will have free time ;)

[Imperat]

@a13821190779 but we need to merge it, of course. Can you open PR?)

[FoxDaxian]

ok @Imperat
and I will continue to pay attention and make good suggestions. :)

[iamkun]

This is an interesting topic and I've change the title a little bit.

[huruji]

oh, a great idea. @a13821190779

[FoxDaxian]

@huruji 哈哈

[guisturdy]

rollup-plugin-uglify plugin will help us do this , and we already using this in build/rollup.config.js.

i think write code like this may not necessary and will made someone that don't know void 0 === undefined hard to understand this code.

code in dayjs.min.js

[iamkun]

@guisturdy Just noticed your comment after merged that PR.

Yes, seems we don't have to do it.

[waitingsong]

undefined is not save, and can be modified .
void 0 alwalys equal to the undifined : assert(typeof (void 0) === 'undeifned)

[iamkun]

great discussion