Datetimepicker: Android build failure with v2.2.0 - RNDatePickerDialogFragment.java:105: error: missing return statement

Created on 3 Feb 2020 · 5Comments · Source: react-native-datetimepicker/datetimepicker

Bug

Android fails to build version 2.2.0.

> Task :@react-native-community_datetimepicker:compileReleaseJavaWithJavac FAILED /data/workspace/AndroidReactBuildNew/node_modules/@react-native-community/datetimepicker/android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java:105: error: missing return statement } ^ Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. 1 error

Environment info

React native info output:

  IDEs:
    Android Studio: 3.4 AI-183.6156.11.34.5522156
    Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
  npmPackages:
    @react-native-community/cli: ^1.9.5 => 1.12.0 
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.4 => 0.60.4

Library version: 2.2.0

Steps To Reproduce

Try to build.

Describe what you expected to happen:

App to build successfully.

Reproducible sample code

Source

nadav2051

👍12 😕1

Most helpful comment

I am returning null as temporary fix not ideal

/node_modules/@react-native-community/datetimepicker/android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java

      DatePickerDialog dialog = new RNDismissableDatePickerDialog(activityContext, onDateSetListener, year, month, day);
      switch (display) {
        case CALENDAR:
          dialog.getDatePicker().setCalendarViewShown(true);
          dialog.getDatePicker().setSpinnersShown(false);
          break;
        case SPINNER:
          dialog.getDatePicker().setCalendarViewShown(false);
          break;
      }
      return dialog;
    }
    return null; // <--- Add this
  }

Screen Shot 2020-02-03 at 11 54 52 AM

kuwaitbinary on 3 Feb 2020

👍3

All 5 comments

Getting the same error here.

chiay on 3 Feb 2020

Same error.

Unforgiven-wanda on 3 Feb 2020

I am returning null as temporary fix not ideal

/node_modules/@react-native-community/datetimepicker/android/src/main/java/com/reactcommunity/rndatetimepicker/RNDatePickerDialogFragment.java

      DatePickerDialog dialog = new RNDismissableDatePickerDialog(activityContext, onDateSetListener, year, month, day);
      switch (display) {
        case CALENDAR:
          dialog.getDatePicker().setCalendarViewShown(true);
          dialog.getDatePicker().setSpinnersShown(false);
          break;
        case SPINNER:
          dialog.getDatePicker().setCalendarViewShown(false);
          break;
      }
      return dialog;
    }
    return null; // <--- Add this
  }

Screen Shot 2020-02-03 at 11 54 52 AM

kuwaitbinary on 3 Feb 2020

👍3

How did a compile a error get past a release... Same issue here, rolling back to 2.1 until then.