Dataverse: Content placed in the "Terms of Access" field via dataset templates does not appear in datasets created with those templates

[BPeuch]

Version: 4.20

Greetings,

It seems that the field "Terms of Access" in the Terms section of a dataset cannot receive content from dataset templates. We've done several tests and the field always remains empty, whether a file was added to the dataset or not. We want to prepopulate it by the use of templates to inform depositors that, if they have chosen a template for datasets with restricted access, they must fill in the "Terms of Access" field.

Possibly related to #2565.

[Edit] I just ran a test to see if this problem also occurs in Demo Dataverse: it does.

[scolapasta]

I was able to verify this - and that others Terms fields do copy (I tried a Data Access Place and Confidentiality Declaration.

I looked at the code and line 265 of TermsOfUseAndAccess.java (copyTermsOfUseAndAccess method) shows them being set, so something less obvious is clearly going on.

retVal.setTermsOfAccess(this.getTermsOfAccess());

[scolapasta]

It's also true of the request access checkbox - my guess is that it's related to this. That both of these are getting unset because there are no files (no restricted files, in particular).

[scolapasta]

More specifically, (and this is still just a guess), there's a popup on that page that sets both those fields (and shows up if you restrict files). So, the hypothesis is that it is replaces the values from the template with these empty values. The solution should be to populate the values into the popup (this also makes sense because when the popup comes up, these should default to the values from the template).

[BPeuch]

Thank you for your feedback @scolapasta! (And sorry for this late reaction. I was on holiday.)