Dataverse: Dataset In Review Notifications - Admin not notified if dataset is "resubmitted"
Currently, admins don't get another notification of a previously submitted dataset being edited and resubmitted for review.
The bigger issue that has been discovered with "In Review" which is the "In Review" is just a flag and does not actually change the state of the dataset (such as changing it from Draft to In Review it is still a Draft just with an extra label on it).
sbarbosadataverse
All 12 comments
The bigger issue that has been discovered with "In Review" which is the "In Review" is just a flag and does not actually change the state of the dataset (such as changing it from Draft to In Review it is still a Draft just with an extra label on it).
Right. See https://github.com/IQSS/dataverse/issues/2554#issuecomment-141967451 for an example of how the boolean seems to work but it isn't always cleared, it seems.
pdurbin
on 21 Sep 2015
Related: #3943.
pdurbin
on 25 Jun 2017
@pameyer is this something you want?
pdurbin
on 30 Jun 2017
@pdurbin : [user submits for review] -> [user remembers something and makes changes] -> [dataset gets kicked out of "in review" state] -> [user submits for review again]; I'd think the second "submit for review" should act the same way as the first one in terms of notifications.
You could make the case for a notification to the curator(s) when a dataset leaves the "in review" state; but the failure mode there is cleaner in the absence of a notification.
pameyer
on 30 Jun 2017
@pameyer ok, I just confirmed via API tests in 886538e that the author gets a notification both times but I'll re-test the GUI after @sekmiller refactors the logic into commands.
pdurbin
on 6 Jul 2017
I believe this bug is fixed in pull request #3992 so I added the "connect to" Waffle syntax to it.
pdurbin
on 14 Jul 2017
@pameyer I see you moved this to the backlog and I assume that means that you don't think pull request #3992 fixed it!
pdurbin
on 14 Nov 2017
@pdurbin moving it back meant that I wanted to check if it was fixed or not
pameyer
on 14 Nov 2017
Oh! Great! Please keep us posted!
pdurbin
on 14 Nov 2017
@pameyer - is this one fixed?
djbrooke
on 16 Jan 2018
@djbrooke - not sure yet. Will need to do an update of our fork prior to testing.
pameyer
on 16 Jan 2018
Finally checked 915c9fa1ff2208e3b0f9ab585ec37bb110651566 (file DOI branch); it's fixed there.
pameyer
on 1 Feb 2018
Related issues
jggautier
路
3Comments
atrisovic
路
3Comments
bsilverstein
路
4Comments
jggautier
路
3Comments
bsilverstein
路
3Comments