Data: [email protected] does not work in IE11

[btecu]

Steps to reproduce:

ember new test-ie
ember build --prod

When trying to browse in IE, the page will stay blank and throw:

SCRIPT5009: 'Symbol' is undefined
vendor.js (85124,5)

[rwjblue]

Thank you for reporting! Definitely seems like a regression.

[raido]

I've just hit the same thing.

This is what is causing it to throw in my case:

[btecu]

It might be related to emberjs/ember.js#18208, which would require a 3.12.1 release, otherwise LTS can't be used if IE11 or Safari 9 are supported.

[raido]

I have pinned it down to Ember Data actually. When ever I upgrade Ember Data to v3.11/v3.12 Symbol('DEBUG-ts-brand') is added to vendor.js and IE 11 fails. I downgraded back to Ember Data v3.10 and kept Ember.js itself v3.12 and my CI passes.

[btecu]

@raido can you search and see if your vendor.js contains any const?

[raido]

@raido can you search and see if your vendor.js contains any const?

Yes, there are few lines of const present in vendor.js with both ED v3.10 and v3.11/v3.12.

Checked by running CI=true ember build --prod.

[runspired]

We should move this to the ember-data repo. @rwjblue

RE Symbol('DEBUG-ts-brand') this will be stripped from production builds. We do have other usage of Symbol that is not guarded by DEBUG though.

RE const unsure where that would be coming from but CI=true ember build --prod does not necessarily target IE11, so I would check your targets.

[runspired]

also fwiw 3.12 is not yet LTS :P

[rwjblue]

RE Symbol('DEBUG-ts-brand') this will be stripped from production builds.

Ya, it should, but it isn't (and there are no if (DEBUG) { guards where it is defined).

[rwjblue]

(moved to emberjs/data)

[raido]

I am targeting IE11 (including Browserstack running tests with IE11). The const is not a that much of a problem for me. The Symbol issue is, so perhaps let's keep this issue focused on that.

[raido]

https://github.com/emberjs/data/blob/63e13baf74ff97a3e08b6d7b1541a64695935316/packages/store/addon/-private/ts-interfaces/utils/brand.ts - basically this is the source of the issue I assume?

[raido]

It seems my testing with v3.11 was actually testing v3.12 anyway - https://github.com/emberjs/data/issues/6378 - because of floating versions.

[runspired]

@dcyriller

[dcyriller]

I'll dig into it

[btecu]

@runspired can we please get a 3.12.1 release with this fix?

[runspired]

@btecu sure, but I believe there is one symbol still not being stripped.

[dcyriller]

The last Symbol to fix is present on master but not in v3.12. I still have to do the fix with WeakMap to solve the whole Symbol issue. I could port the current fix to 3.12 if you think it makes sense.

[runspired]

@dcyriller lets port the current fix so that we can fix 3.12 then get back to the WeakMap fix

[runspired]

3.12.1 with this fix has been released

[btecu]

Unfortunately, ember-data 3.12.1 still doesn't work with IE11.
I now get a different error:

I saw there's issue #6326 about this, not specific to IE.
I do have "jquery-integration": true.