Dashboard: Make URLs in logs clickable

Created on 14 Jan 2020  路  10Comments  路  Source: tektoncd/dashboard

Being able to click on URLs in the log output would be very useful.

The ansi-to-react component we currently use to render the logs has support for this via the linkify prop but it has a number of bugs / limitations.

See https://github.com/tektoncd/dashboard/pull/873#issuecomment-574293426 for more.

kinfeature

Most helpful comment

I raised a point about https://stackoverflow.com/questions/62771252/execute-maven-based-end-to-end-tests-and-display-result-in-tekton-dashboard/62791025#62791025 ...

The creator of the Stackoverflow-ticket is on board, too :) Hi folks, thanks for your helpful reaction! As my knowledge of Tekton will get more I hope I'll be able to contribute a bit in return.

To provide more context: We use Tekton for a German federal agency to simplify the CD-workflow on k8s.
One question about this issue:
I intended to run the e2e-maven-tasks within Tekton. Is Tekton retaining the the logs and artifacts generated during a task-run (as Jenkins is retaining the output of a job), so these resources would be automatically persisted and linkable?

All 10 comments

To consider:

react-linkify and ansi-to-react don't seem to work together by default, some further investigation required.

I raised a point about https://stackoverflow.com/questions/62771252/execute-maven-based-end-to-end-tests-and-display-result-in-tekton-dashboard/62791025#62791025 in Slack and @AlanGreene's noticed and linked to this issue as something we may want to revisit (I've added a comment on that issue too so it's all in sync)

I raised a point about https://stackoverflow.com/questions/62771252/execute-maven-based-end-to-end-tests-and-display-result-in-tekton-dashboard/62791025#62791025 ...

The creator of the Stackoverflow-ticket is on board, too :) Hi folks, thanks for your helpful reaction! As my knowledge of Tekton will get more I hope I'll be able to contribute a bit in return.

To provide more context: We use Tekton for a German federal agency to simplify the CD-workflow on k8s.
One question about this issue:
I intended to run the e2e-maven-tasks within Tekton. Is Tekton retaining the the logs and artifacts generated during a task-run (as Jenkins is retaining the output of a job), so these resources would be automatically persisted and linkable?

/assign @stevesoaress

@AlanGreene: GitHub didn't allow me to assign the following users: stevesoaress.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @stevesoaress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This is in progress. We have a new LogFormat component which handles additional ANSI codes and also makes URLs clickable. It should be enabled for the next release.

/remove-lifecycle rotten
/reopen

@AlanGreene: Reopened this issue.

In response to this:

This is in progress. We have a new LogFormat component which handles additional ANSI codes and also makes URLs clickable. It should be enabled for the next release.

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

a-roberts picture a-roberts  路  6Comments

alan-ghelardi picture alan-ghelardi  路  5Comments

eddycharly picture eddycharly  路  6Comments

adunderwood picture adunderwood  路  3Comments

a-roberts picture a-roberts  路  4Comments