Dashboard: Add language setting in local setting.

[hwdef]

What would you like to be added

language setting in local setting

Why is this needed

In most browsers, when the region is China, the default language is zh-CN, it can not match zh, so dashboard will display English.

Chinese has four branch: zh-CN , zh-TW, zh-HK, zh-SG, correspond to China, Taiwan, Hong Kong and Singapore.

I think adding an option for language settings is an easy and intuitive way to solve this.

Comments

[tanjunchen]

/lgtm

[tanjunchen]

[floreks]

In most browsers, when the region is China, the default language is zh-CN, it can not match zh, so dashboard will display English.

That is not really an issue. We can simply add translation for zh-CN. If base is the same as zh then it's as simple as creating new directory named zh-CN and copying the translation file.

It would be harder to let user choose language as backend auto-discovers and handles serving translations on a single endpoint and we would need to dynamically add endpoint per translation to handle it similar to i.e. Kubernetes docs.

[hwdef]

@floreks
Thanks for your suggestion , it is good.
I can add a new directory named zh-CN.
But it creates a new problem, Chinese includes Simplified Chinese and Traditional Chinese, zh-cn and zh-sg is Simplified Chinese, zh-TW and zh-HK is Traditional Chinese. the zh folder need to make a choice.I think the zh folder is best kept as it is now, Simplified Chinese. Because Simplified Chinese has the most users. What do you think about it.

[floreks]

@hwdef I think we should have all directories zh, zh.CN, zh-TW, etc. Depending on what locale browser will present, the exact directory will be chosen for translation. For example it looks like chrome supports zh_CN and zh_TW as locale information.

https://developer.chrome.com/webstore/i18n#localeTable

We should check other browsers and decide how to name our i18n directories.

[hwdef]

@floreks
I can create all the directories, but I cannot write Traditional Chinese.So zh-TW and zh-HK will keep Simplified Chinese until someone has translated Traditional Chinese.

In firefox ,there are more settings,I should create zh-CN, zh-TW and zh-HK.

[floreks]

We should have all of them then. I am not familiar with dialect differences between them so you can decide what hierarchy would be best.

[hwdef]

ok,I will do it later.
Thanks for your suggestions.

[zehuaiWANG]

@hwdef @floreks @shu-mutou I agree that maybe we should take Traditional Chinese into consideration. Please pay attention that we shoud also modify the i18n/locale_conf.json, i18n/locale_conf.json and docs/developer/internationalization.md file if we want to add a new one. By the way, I'm familiar with the writing of traditional Chinese. If you don't mind, I can help to do it.

[zehuaiWANG]

In addition, I think it's reasonable to add the language switch button on dashboard‘s page, because we may not be able to handle the language settings of all browsers.

[shu-mutou]

This might be basic, but could you tell me follows?
[1] Are zh, zh-cn and hz-sg the same Simplified Chinese?
[2] Are zh-tw and zh-hk the same Traditional Chinese?

If [1] and [2] are true that mean we need only two translation files, i.e. simplified and traditional, but we need five locales, i.e. zh, zh-cn, zh-sg, zh-tw and zh-hk, my PoC would work fine for this situation.

If my PoC satisfies Chinese requisites and you have not work for this yet, I can create PR from my PoC. Please let me know if I can submit my PoC. If you are working for this issue already, feel free to refer my PoC.

If we need to translate for each locales, please create each directories for them, i.e. zh-cn, zh-sg, zh-tw and zh-hk, and translate them according to docs.

[hwdef]

@shu-mutou
[1] and [2] are true ,your opinion is right, we just need two translation files.

I read you PoC, at first glance, it is correct.But there is a problem we need to pay attention to,

the 'zh-cn' in browser is 'zh-CN', I am not sure how to solve this.
What do you think about it ?

[shu-mutou]

@hwdef zh-CN from browser would be calcurated as zh-cn by serverside. So it's correct to set zh-cn on serverside for zh-CN.

[hwdef]

@shu-mutou
I got it thank you

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[shu-mutou]

due to https://github.com/kubernetes/dashboard/issues/5027#issuecomment-604191754

[gonejack]

Hi @shu-mutou .

This page keep showing up with Japanase, have no idea why this happending, cleaning cookie not working, changing chrome locale not working.

All I did was:

kubectl apply -f https://raw.githubusercontent.com/kubernetes/dashboard/v2.0.3/aio/deploy/recommended.yaml
kubectl proxy

[floreks]

Try disabling cache and refresh. I am not entirely sure right now if we support locales with priorities such as in your request header.

[gonejack]

@floreks thx it works!