Dashboard: Dashboard should not use CreatedByAnnotation

[crimsonfaith91]

Based on this announcement, CreatedByAnnotation will be deprecated in 1.8 in favor of ControllerRef. However, the annotation is still used in this repo: here and here

There is a necessary change to use ControllerRef. Does anyone have bandwidth to work on this?

[zouyee]

@maciaszczykm

[maciaszczykm]

@crimsonfaith91 Thanks for the information. We migrated most of our backend to use controller references, but this is not finished as you correctly pointed out. We will take care of it before 1.8.

[crimsonfaith91]

@maciaszczykm Will you or someone work on this? I am happy to review the PR.

[crimsonfaith91]

@maciaszczykm I can work on this if needed.

[maciaszczykm]

@maciaszczykm I can work on this if needed.

@crimsonfaith91 Would be great :)

[crimsonfaith91]

@maciaszczykm After examining the workload, i think i will let you or someone else who is familiar with the codebase to make the change. It will take some time to learn the codebase before making the change to use ControllerRef, but i do not have the bandwidth (it looks like the required change will be quite different compared to main kubernetes/kubernetes repo).

Will you be fine with this?

[crimsonfaith91]

@maciaszczykm I suggest using ControllerRef rather than OwnerReference. To clarify, OwnerReference is the more general feature that ControllerRef is built on. A ControllerRef is just an OwnerReference with the Controller field set to true. There can be only one OwnerReference that is a ControllerRef on a given object.

Some good references for implementation purpose:
https://github.com/kubernetes/kubernetes/pull/47469
https://github.com/kubernetes/kubernetes/pull/47471

[maciaszczykm]

@crimsonfaith91 Thanks, we will take care of that :+1: Also good to know about ControllerRef field, I had to miss it somehow.