Dash-to-panel: D2P is broken on GNOME 3.30 | global.screen is undefined

[alex285]

Hello! This is a bit early but Dash To Panel doesn't work on GNOME Shell 3.29.3.

It throws

Extension "[email protected]" had error: TypeError: global.screen is undefined

And it now only places panel on bottom

I think the problem is on Remove usage of MetaScreen commit in GNOME Shell

[franglais125]

Have a look at this PR from dash-to-dock: https://github.com/micheleg/dash-to-dock/pull/770 (thanks to @3v1n0 )

[alex285]

@franglais125 thanks for the PR link! I patched DtP similar, but for some reason JHbuild Shell now crashes (even without the extension enabled) and i cant fix it :( I will wait till Fedora29 (im using) to push 3.29.3 and retest

[jderose9]

Thanks for the heads up. I'll work on this. Are you using Rawhide?

[alex285]

@jderose9 yes but 3.29.3 hasn't published yet on their repos, and not sure what happened with my JHBuild and crashes now. I rebuilt everything! And it was a golden opportunity for my first patch :(

[jderose9]

@alex285 Looks like Rawhide repos have 3.29.4 now. Did you want to take a stab at it?

[alex285]

@jderose9 actually im just about! got it last night!

[cnd]

maybe you know working topicons plus alternative too?

[jderose9]

@cnd Does this one work?
https://extensions.gnome.org/extension/615/appindicator-support/

[3v1n0]

@jderose9 yes, no changes involved there.

[horvathz]

Just a simple patch. It works with 3.29.4. And it breaks 3.28.x of course.

[vans163]

I love Gnome foundation, they work like a fully automatic shotgun, hang up Gnome API as a target, close eyes, spray shells, open eyes, major_version++, release.

[3v1n0]

@horvathz Using a wrapper like done in https://github.com/micheleg/dash-to-dock/pull/770 will keep compatibility with both.

It can be cleaner, but that's the fastest and simplest solution ;-)

[Prototik]

@jderose9 You forgot to import imports.gi.Meta in latest 6206195 commit. It still doesn't work on 3.30 without it.

[jderose9]

@Prototik Thank! Give it a shot now. I believe everything should be working with 3.30 as expected.

[Prototik]

@jderose9 yeah, with fixed import it works like a charm.