Dart-code: Add an option to control hot-reload-on-save behaviour when using auto-save

Created on 31 Jan 2021 · 6Comments · Source: Dart-Code/Dart-Code

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Run a project
Edit it while having the auto-save setting enabled

Expected behavior
On completion of auto-save, hot reload should've been triggered. But instead, its not triggered until manual save/reload

Versions (please complete the following information):

VS Code version: 1.52.1
Dart extension version: 3.19.1
Dart/Flutter SDK version: 2.12.0-133.7.beta/1.25.0-8.3.pre

in editor in flutter is enhancement

Source

skateboarder

👍2

Most helpful comment

If this was working well for some, then I think it's probably fair to have a setting to control it (perhaps extend the existing setting to be an enum for on/off/manual or similar).

DanTup on 31 Jan 2021

👍10 🚀3 ❤3 🎉2 😄2 👀1

All 6 comments

This is intended behavior! See #3033.

RandalSchwartz on 31 Jan 2021

If this was working well for some, then I think it's probably fair to have a setting to control it (perhaps extend the existing setting to be an enum for on/off/manual or similar).

DanTup on 31 Jan 2021

👍10 🚀3 ❤3 🎉2 😄2 👀1

This is one of the best feature and why i chose VSCode as my primary IDE. Should've make it optional since it works well on mac. Just my 2 cents.

encikpulasan on 2 Feb 2021

👍7

I guess I underestimated how many people were using this without issues! The dart.flutterHotReloadOnSave will be updated to be an enum in the next release:

dart.flutterHotReloadOnSave

Whether to automatically send a Hot Reload request during a debug session when saving files.

never - do not reload when saving.
always - reload for all saves, manual or automatic.
manual - only reload for manual saves (requires pressing Save explicitly if using autosave).

DanTup on 2 Feb 2021

🎉9 👍7 🚀1

This change hasn't landed yet, so keeping this open until it does.

DanTup on 3 Feb 2021

I guess I underestimated how many people were using this without issues! The dart.flutterHotReloadOnSave will be updated to be an enum in the next release:

dart.flutterHotReloadOnSave

Whether to automatically send a Hot Reload request during a debug session when saving files.

never - do not reload when saving.

always - reload for all saves, manual or automatic.

manual - only reload for manual saves (requires pressing Save explicitly if using autosave).

Worked for me, Thanks..