Darktable: Prominent message needed when a change in preferences requires dt to be restarted

[RawConvert]

I have the three items in preferences/processing about auto applying basecurve and sharpening unticked. However when I import a new raw and go into darktable, these modules are On (surely they should be Off). And to be sure, just before importing the new image, I ensure they are Off in the current image.

This is Master - dt 3.1.0+1837~gee49c4778-dirty built today 30/5/2020. Ubuntu 18.04

[johnny-bit]

I've noticed the same and can confirm this behaviour :/ this is NOT intended.

[elstoc]

From what I can tell if you exit darktable and then reopen it the settings work fine. It's when you change them mid-session that they don't work, at least for me.

This is because the modules set an internal variable "autoapply" when the module is initially loaded and from then on ignore the preference setting.

[elstoc]

Given that these settings probably won't be changed very often it might be better to just add a "requires restart" comment against the preference setting. Edit: oh there already is one.

[johnny-bit]

If that's the case with some of the settings we need to identify them and
add to those "* requires restart" note.

sob., 30 maj 2020 o 17:55 elstoc [e-mail] napisał(a):

From what I can tell if you exit darktable and then reopen it the settings
work fine. It's when you change them mid-session that they don't work, at
least for me.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/darktable-org/darktable/issues/5241#issuecomment-636349974,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACRRKFKU2PWECK4QJ33IDSLRUET5XANCNFSM4NOXSAHQ
.

--
Pozdrawiam,
Hubert Kowalski

[elstoc]

I didn't notice when I posted the first comment but the tooltips for those settings already say that. So, I guess this is working as designed then.

[johnny-bit]

According to darktableconfig.xml.in there's grand total of 19 settings which require restart. Would it be possible in any way to have "needs restart" indication more prominent than tooltip?

I mean any from the possible things like:

• indicate field with :warning:
• when user changes setting that requires a restart - throw dialog that say "this needs restart to apply [OK]"
• when saving settings and settings that require restart are changed - throw a dialog "some settings which require restart were changed. please restart darktable to have them applied [OK]"

That would avoid any problematic issues with restart-required settings ;)

[RawConvert]

Yes I see if I exit and go back in then those modules are now off.
I think a prominent warning and/or option to restart would be good.

[elstoc]

Sounds like a good idea.

[GrahamByrnes]

The list may not be complete: preview_downsampling requires a restart, but isn't marked as such.
There may be others...
(Yes, it's a project to fix it, although I don't understand what it's doing atm).

[jenshannoschwalm]

indicate field with warning

I think we could have just cumulative flag indicated by such a sign at a prominent position to be seen in dr and lt

[github-actions[bot]]

This issue did not get any activity in the past 30 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

[RawConvert]

Just tested in dt 3.2.1 release. Issue remains.

[RawConvert]

* Thanks for fixing *