Dapper: Update System.Data.SqlClient to 4.5 version

Created on 17 May 2018  Â·  6Comments  Â·  Source: StackExchange/Dapper

Hello,

There is an important fix released in System.Data.SqlClient in version 4.5 as described here:
https://github.com/dotnet/corefx/issues/24282
Could you please update package dependency to the current version?

Regards
wb

Most helpful comment

@whitebear-gh Just trying to understand the motivation here: what's the reason for Dapper to force the upgrade? You are absolutely fine to directly use 4.5 in your <PackageReference> alongside Dapper and it'll use the newer version, while not forcing everyone else to upgrade.

Note that at this time, System.Data.SqlClient 4.5.0 is not stable, so we cannot depend on it. But as said above, you're perfectly fine to begin using it!

All 6 comments

In theory... "Fine I guess"? Note: closing this means it is likely to
disappear off of our radar.

On Thu, 17 May 2018, 20:19 whitebear-gh, notifications@github.com wrote:

Closed #1026 https://github.com/StackExchange/Dapper/issues/1026.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/StackExchange/Dapper/issues/1026#event-1632760931,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABDsA3pr4p3uktKzyf_IjQ-IWquUoYTks5tzc1WgaJpZM4UDnm-
.

Sorry, I have closed it somehow by mistake I guess, It's still on the table.

@whitebear-gh Just trying to understand the motivation here: what's the reason for Dapper to force the upgrade? You are absolutely fine to directly use 4.5 in your <PackageReference> alongside Dapper and it'll use the newer version, while not forcing everyone else to upgrade.

Note that at this time, System.Data.SqlClient 4.5.0 is not stable, so we cannot depend on it. But as said above, you're perfectly fine to begin using it!

I've ran into this issue as well. For someone who's using Dapper directly and is not aware that a transient dependency System.Data.SqlClient, versions earlier than 4.5.0, will not work with TransactionScope is not trivial to figure out.

We did this, but also removed the reference later on, because of the migration to Microsoft.Data.SqlClient, so Dapper now relies on neither and is agnostic. Closing out to tidy up!

I missed your previous message, but thanks for your help Nick!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

silkfire picture silkfire  Â·  4Comments

CrescentFresh picture CrescentFresh  Â·  4Comments

ishamfazal picture ishamfazal  Â·  5Comments

yozawiratama picture yozawiratama  Â·  5Comments

huobazi picture huobazi  Â·  4Comments