Danger: Investigate what's going on with Danger's CHANGELOG notice

Created on 6 Jul 2016  路  9Comments  路  Source: danger/danger

screen shot 2016-07-06 at 9 47 21 am

Could it be different build envs are returning different commit ranges?

Bug

All 9 comments

Could it be different build envs are returning different commit ranges?

This sounds like what I might be seeing where Danger is showing this when running on our CI, but not locally:

but the PR is only ~50 lines

I'd recommend running with --verbose to see if anything feels out of alignment, it should echo all of Danger's internal values for this stuff 馃憤

It's how I was thinking of debugging this one anyway

If only Fastlane's danger plugin respected the --verbose flag when you pass it in ^-^

Hah - Make it do that 馃懐

That's the plan when I have some time in the next few days, along with https://github.com/danger/danger/issues/282

@dzlobin Unless I'm misunderstanding something, it does respect: https://github.com/fastlane/fastlane/blob/master/fastlane/lib/fastlane/actions/danger.rb#L10

@marcelofabri I actually just fixed that, complete PEBKAC error.

Also worth noting my problem above was related to #305

I don't think this is happening anymore, at least we're not seeing on artsy or danger

Was this page helpful?
0 / 5 - 0 ratings

Related issues

samdmarshall picture samdmarshall  路  6Comments

tbrand picture tbrand  路  6Comments

josete89 picture josete89  路  10Comments

brettha picture brettha  路  9Comments

kylejm picture kylejm  路  4Comments