Dagger: ContributesAndroidInjector support for androidx.lifecycle.ViewModel

[sh4wn]

is there any plan for support androidx.lifecycle.ViewModel with @ContributesAndroidInjector?

[Vichy97]

Also wondering this same thing

[wlodzix]

+1

[ronshapiro]

We need to think through a few things, but the short answer is yes.

[Vichy97]

Is there a timeline on that?

[igokoro]

Would be really useful. Already got burned by this when implemented such injection myself. It turns out, depending on how/when you inject Fragment (in my case), dagger may "help" retain a "cleared" ViewModel instance. A quick fix in my case was to use Provider<> to get a just-in-time "alive" instance of my ViewModel.

It would also be extremely convenient if dagger could generate ViewModel Factories. From what I understand, the thing is a necessary (evil) piece of boilerplate code required by the framework. It has no other development value. Dagger could derive Factory implementation from injectable ViewModel constructor.

[matejdro]

Dagger could derive Factory implementation from injectable ViewModel constructor.

See my comment here, you can create that factory easily yourself.

[Chang-Eric]

I'm closing this since with the release of Hilt and the Jetpack extension for ViewModels using Hilt, I think this feature request for dagger.android is unlikely to be done.

[tir38]

This is what @Chang-Eric is referring to: https://developer.android.com/training/dependency-injection/hilt-jetpack#viewmodels

Sadly I wish there was a "vanilla" Dagger (aka w/out dagger-android or Hilt) way of doing this.

[tasomaniac]

Vanilla Dagger is platform agnostic. That's why it is vanilla 😉

[tir38]

Yeah I was complaining about ViewModel implementation, not Dagger =) It's a bummer they didn't give us constructor access.