Dagger: Bundled Android Proguard rules in 2.15 not taking effect

Created on 9 Mar 2018  路  6Comments  路  Source: google/dagger

I've had -dontwarn com.google.errorprone.annotations.* in my project's proguard rules for a while now waiting for dagger's consumer rules to be bundled. I saw a related PR was merged for 2.15 so I've tried building without that line in my project's rules and I still get the same handful of "can't find referenced class" errors pointing to that package that I was getting prior to 2.15.

Most helpful comment

That only fixed things for Bazel users. Bazel is not (yet) actually adding it to the aar though (it uses it in its internal implementation)

All 6 comments

You're right, I'm not seeing those in the packaged aar. I'll investigate

Apparently it's not included in the aar in Bazel...

@ronshapiro Was this not the correct fix, https://github.com/google/dagger/pull/1059? Or does bazel have a separate issue on their end?

That only fixed things for Bazel users. Bazel is not (yet) actually adding it to the aar though (it uses it in its internal implementation)

This is now in bazel, and at least working in 2.17, possibly 2.16 too.

Was this page helpful?
0 / 5 - 0 ratings