Cz-cli: "improvement" offered as an option but not in enum

Created on 12 Oct 2019  ·  5Comments  ·  Source: commitizen/cz-cli

When using git cz, one option for a type to select is "improvement", but this fails the enum check

husky > commit-msg hook failed (add --no-verify to bypass)
git exited with error code 1
kris@Kriss-MacBook-Pro cent-admin % git cz
[email protected], [email protected]

? Select the type of change that you're committing: 
  revert:      Reverts a previous commit 
  feat:        A new feature 
  fix:         A bug fix 
❯ improvement: An improvement to a current feature 
  docs:        Documentation only changes 



⧗   input: improvement(employers): added new subscriptions
✖   type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Most helpful comment

@OmgImAlexis @ktwbc @jimthedev It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I'm proposing we consider removing it in https://github.com/commitizen/conventional-commit-types/pull/16, so I would appreciate if you could share thoughts there.

All 5 comments

@jimthedev since https://github.com/conventional-changelog/commitlint/pull/832 has been merged can we get config-conventional's version bumped please.

@OmgImAlexis @ktwbc @jimthedev It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I'm proposing we consider removing it in https://github.com/commitizen/conventional-commit-types/pull/16, so I would appreciate if you could share thoughts there.

Was this page helpful?
0 / 5 - 0 ratings