Cypress: Warning about deprecated sub-dep 'har-validator' when installing cypress

[crfrolik]

Current behavior:

warning cypress > @cypress/request > [email protected]: this library is no longer supported

Desired behavior:

No warning

Test code to reproduce

yarn install

Versions

Cypresss 4.12.1

[jennifer-shehane]

Replaced by https://github.com/ahmadnassri/har-cli - we'd be open to a pull request to replace this in @cypress/request here: https://github.com/cypress-io/request

[jennifer-shehane]

Related to #6730

[jennifer-shehane]

I don't really see this cli util being a 1 to 1 replacement honestly.

[bahmutov]

Kind of annoying to see it

$ npm i -D cypress
npm WARN deprecated [email protected]: this library is no longer supported

> [email protected] postinstall /Users/gleb/git/cypress-test-tiny/node_modules/cypress
> node index.js --exec install

+ [email protected]

[ramaiahkethana]

Hi @jennifer-shehane , I want to contribute to this issue.

Are you talking about remove the dependency or update the dependency?

[ramaiahkethana]

I checked the details of the npm package and it shows it is no longer supported.

I think it should be deleted from the dependencies.

[jennifer-shehane]

$ yarn why har-validator
yarn why v1.22.0
[1/4] 🤔  Why do we have the module "har-validator"...?

=> Found "[email protected]"
info Has been hoisted to "har-validator"
info Reasons this module exists
   - "workspace-aggregator-c80b5799-973a-422e-82ee-a6edb3304878" depends on it
   - Hoisted from "_project_#request#har-validator"
   - Hoisted from "_project_#@cypress#request#har-validator"

=> Found "node-webkit-updater#[email protected]"
info Reasons this module exists
   - "_project_#@packages#server#node-webkit-updater#request" depends on it
   - Hoisted from "_project_#@packages#server#node-webkit-updater#request#har-validator"

This PR will partially address this https://github.com/cypress-io/cypress/pull/8807 - removing the har-validator by removing the node-webkit-updater package.

@christyram99 We would need the har-validator plugin to be replaced with the same functionality in our https://github.com/cypress-io/request repo.

Or for us to replace our https://github.com/cypress-io/request library with similar functionality in our cypress repo.